[PATCH] soc: fsl: qe: Check of ioremap return value in qe_reset

2022-06-13 Thread Li Qiong
As the possible failure of the ioremap(), the qe_immr could be NULL. Therefore it should be better to check it and print error message. Signed-off-by: Li Qiong --- drivers/soc/fsl/qe/qe.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c

Re: [PATCH] soc: fsl: qe: Check of ioremap return value

2022-01-06 Thread Li Yang
On Thu, Dec 30, 2021 at 9:47 AM Jiasheng Jiang wrote: > > As the possible failure of the ioremap(), the par_io could be NULL. > Therefore it should be better to check it and return error in order to > guarantee the success of the initiation. > But, I also notice that all the caller like

[PATCH] soc: fsl: qe: Check of ioremap return value

2021-12-29 Thread Jiasheng Jiang
As the possible failure of the ioremap(), the par_io could be NULL. Therefore it should be better to check it and return error in order to guarantee the success of the initiation. But, I also notice that all the caller like mpc85xx_qe_par_io_init() in `arch/powerpc/platforms/85xx/common.c` don't