Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Greg KH
On Thu, Aug 25, 2011 at 01:51:20PM -0500, Timur Tabi wrote: > Greg KH wrote: > > But don't you really want this type of check at runtime? What happens > > if you load this driver on a machine that is not a guest? Will things > > break? Shouldn't you still refuse to load somehow? > > This is in

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
Greg KH wrote: > But don't you really want this type of check at runtime? What happens > if you load this driver on a machine that is not a guest? Will things > break? Shouldn't you still refuse to load somehow? This is in the udbg code, which falls under the category of, "turn this on only if

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Greg KH
On Thu, Aug 25, 2011 at 01:02:01PM -0500, Timur Tabi wrote: > Greg KH wrote: > > tested doesn't mean that it shouldn't still build properly for other > > platforms, right? > > The problem is the dependency on MSR_GS, which is defined only for Book-E > PowerPC chips, not all PowerPC. > > So I gave

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
Greg KH wrote: > tested doesn't mean that it shouldn't still build properly for other > platforms, right? The problem is the dependency on MSR_GS, which is defined only for Book-E PowerPC chips, not all PowerPC. So I gave it some more thought, and technically ePAPR extends beyond Book-E, so it's

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Greg KH
On Thu, Aug 25, 2011 at 11:20:45AM -0500, Timur Tabi wrote: > The Kconfig for the ePAPR hypervisor byte channel driver has a "depends on > PPC", > which means it would compile on all PowerPC platforms, even though it's > only been tested on Freescale platforms. Change the Kconfig to depend on > F

[PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
The Kconfig for the ePAPR hypervisor byte channel driver has a "depends on PPC", which means it would compile on all PowerPC platforms, even though it's only been tested on Freescale platforms. Change the Kconfig to depend on FSL_SOC instead. Signed-off-by: Timur Tabi --- drivers/tty/Kconfig |