Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-24 Thread Felipe Balbi
On Wed, Nov 23, 2011 at 08:20:54AM +, Li Yang-R58472 wrote: > >Leo, I have debugged this issue at my board just now, the reason of > >failure is we only have one ep struct for ep0, so when talking about ep0, > >it always pointers to udc->ep[0]. So even we initialize the current qh > >address fo

RE: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-23 Thread Li Yang-R58472
TCH] usb/fsl_udc: fix dequeuing a request in progress > >On Tue, Nov 22, 2011 at 7:48 PM, Peter Chen wrote: >>>>It seems to can't get the correct qh pointer, you may still need to >>>>use below code to get it >>>>       int i = ep_index(ep) * 2 + ep

Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-22 Thread Peter Chen
On Tue, Nov 22, 2011 at 7:48 PM, Peter Chen wrote: >>>It seems to can't get the correct qh pointer, you may still need to use >>>below code to get it >>>       int i = ep_index(ep) * 2 + ep_is_in(ep); >>>       struct ep_queue_head *dQH = &ep->udc->ep_qh[i]; >> >> Thanks for trying.    It will be

Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-22 Thread Peter Chen
>>It seems to can't get the correct qh pointer, you may still need to use >>below code to get it >>       int i = ep_index(ep) * 2 + ep_is_in(ep); >>       struct ep_queue_head *dQH = &ep->udc->ep_qh[i]; > > Thanks for trying.    It will be much easier if we can dereference QH from > the ep struct

RE: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-22 Thread Li Yang-R58472
>Subject: Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress > >On Fri, Nov 11, 2011 at 08:38:13PM +0800, Li Yang wrote: >> The original implementation of dequeuing a request in progress is not >> correct. Change to use a correct process and also clean up the &

Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-22 Thread Peter Chen
On Fri, Nov 11, 2011 at 08:38:13PM +0800, Li Yang wrote: > The original implementation of dequeuing a request in progress > is not correct. Change to use a correct process and also clean > up the related functions a little bit. > > Signed-off-by: Li Yang > --- > drivers/usb/gadget/fsl_udc_core.

[PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-11 Thread Li Yang
The original implementation of dequeuing a request in progress is not correct. Change to use a correct process and also clean up the related functions a little bit. Signed-off-by: Li Yang --- drivers/usb/gadget/fsl_udc_core.c | 62 +--- 1 files changed, 29 inse