Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-05-22 Thread Li Yang
On Tue, Apr 14, 2020 at 4:13 AM Tang Bin wrote: > > Hi > > On 2020/4/14 16:30, Dan Carpenter wrote: > > On Fri, Apr 10, 2020 at 04:05:06PM +0800, Tang Bin wrote: > >>> > Thus it must be fixed. > >>> Wording alternative: > >>> Thus adjust the error detection and corresponding exception

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-14 Thread Tang Bin
Hi On 2020/4/14 16:30, Dan Carpenter wrote: On Fri, Apr 10, 2020 at 04:05:06PM +0800, Tang Bin wrote: Thus it must be fixed. Wording alternative: Thus adjust the error detection and corresponding exception handling. Got it. Wow... No, don't listen to Markus when it comes to writing

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-14 Thread Dan Carpenter
On Fri, Apr 10, 2020 at 04:05:06PM +0800, Tang Bin wrote: > > > > > > > Thus it must be fixed. > > Wording alternative: > >Thus adjust the error detection and corresponding exception handling. > > Got it. Wow... No, don't listen to Markus when it comes to writing commit messages. You

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Sergei Shtylyov
On 10.04.2020 4:58, Tang Bin wrote: If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. platform_get_irq() prints an

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Sergei Shtylyov
Hello! On 10.04.2020 4:58, Tang Bin wrote: If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. Signed-off-by: Tang Bin

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Tang Bin
Hi Markus On 2020/4/10 15:33, Markus Elfring wrote: If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", I suggest to adjust this change description. Wording alternative: The negative return value (which could

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Markus Elfring
> If the function "platform_get_irq()" failed, the negative value > returned will not be detected here, including "-EPROBE_DEFER", I suggest to adjust this change description. Wording alternative: The negative return value (which could eventually be “-EPROBE_DEFER”) will not be detected here

[PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-09 Thread Tang Bin
If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang ---