Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-15 Thread Darrick J. Wong
On Tue, Oct 15, 2019 at 09:10:04AM -0400, Theodore Y. Ts'o wrote: > On Tue, Oct 15, 2019 at 01:01:02AM -0700, Christoph Hellwig wrote: > > On Mon, Oct 14, 2019 at 03:09:48PM -0500, Eric Sandeen wrote: > > > We're in agreement here. ;) I only worry about implementing things like > > > this > > >

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-15 Thread Theodore Y. Ts'o
On Tue, Oct 15, 2019 at 01:01:02AM -0700, Christoph Hellwig wrote: > On Mon, Oct 14, 2019 at 03:09:48PM -0500, Eric Sandeen wrote: > > We're in agreement here. ;) I only worry about implementing things like > > this > > which sound like guarantees, but aren't, and end up encouraging bad behavior

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-15 Thread Christoph Hellwig
On Tue, Oct 15, 2019 at 09:56:20AM +0800, Pingfan Liu wrote: > Agree. For the consistency of the whole fs, we need grub to be aware of > log. While this patch just assumes that files accessed by grub are > known, and the consistency is forced only on these files. > > get by freezing and unfreezing

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-15 Thread Christoph Hellwig
On Mon, Oct 14, 2019 at 03:09:48PM -0500, Eric Sandeen wrote: > We're in agreement here. ;) I only worry about implementing things like this > which sound like guarantees, but aren't, and end up encouraging bad behavior > or promoting misconceptions. > > More and more, I think we should reconsid

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Pingfan Liu
On Mon, Oct 14, 2019 at 10:03:03PM +0200, Jan Kara wrote: > On Mon 14-10-19 08:23:39, Eric Sandeen wrote: > > On 10/14/19 4:43 AM, Jan Kara wrote: > > > On Mon 14-10-19 16:33:15, Pingfan Liu wrote: > > > > On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: > > > > > On Sun, Oct 13, 20

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Pingfan Liu
On Mon, Oct 14, 2019 at 08:23:39AM -0500, Eric Sandeen wrote: > On 10/14/19 4:43 AM, Jan Kara wrote: > > On Mon 14-10-19 16:33:15, Pingfan Liu wrote: > > > On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: > > > > On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > > > > >

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Pingfan Liu
On Mon, Oct 14, 2019 at 01:40:27AM -0700, Christoph Hellwig wrote: > On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > > When using fadump (fireware assist dump) mode on powerpc, a mismatch > > between grub xfs driver and kernel xfs driver has been obsevered. Note: > > fadump boots up

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Eric Sandeen
On 10/14/19 3:03 PM, Jan Kara wrote: On Mon 14-10-19 08:23:39, Eric Sandeen wrote: On 10/14/19 4:43 AM, Jan Kara wrote: On Mon 14-10-19 16:33:15, Pingfan Liu wrote: On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote:

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Jan Kara
On Mon 14-10-19 08:23:39, Eric Sandeen wrote: > On 10/14/19 4:43 AM, Jan Kara wrote: > > On Mon 14-10-19 16:33:15, Pingfan Liu wrote: > > > On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: > > > > On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > > > > > When using fadu

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Eric Sandeen
On 10/14/19 4:43 AM, Jan Kara wrote: On Mon 14-10-19 16:33:15, Pingfan Liu wrote: On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: When using fadump (fireware assist dump) mode on powerpc, a mismatch between grub xfs

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Jan Kara
On Mon 14-10-19 16:33:15, Pingfan Liu wrote: > On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: > > On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > > > When using fadump (fireware assist dump) mode on powerpc, a mismatch > > > between grub xfs driver and kernel xfs dr

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Christoph Hellwig
On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > When using fadump (fireware assist dump) mode on powerpc, a mismatch > between grub xfs driver and kernel xfs driver has been obsevered. Note: > fadump boots up in the following sequence: fireware -> grub reads kernel > and initramfs -

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-14 Thread Pingfan Liu
On Sun, Oct 13, 2019 at 09:34:17AM -0700, Darrick J. Wong wrote: > On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > > When using fadump (fireware assist dump) mode on powerpc, a mismatch > > between grub xfs driver and kernel xfs driver has been obsevered. Note: > > fadump boots up i

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-13 Thread Darrick J. Wong
On Sun, Oct 13, 2019 at 10:37:00PM +0800, Pingfan Liu wrote: > When using fadump (fireware assist dump) mode on powerpc, a mismatch > between grub xfs driver and kernel xfs driver has been obsevered. Note: > fadump boots up in the following sequence: fireware -> grub reads kernel > and initramfs -

[PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-13 Thread Pingfan Liu
When using fadump (fireware assist dump) mode on powerpc, a mismatch between grub xfs driver and kernel xfs driver has been obsevered. Note: fadump boots up in the following sequence: fireware -> grub reads kernel and initramfs -> kernel boots. The process to reproduce this mismatch: - On power