Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-06-27 Thread Benjamin Herrenschmidt
On Mon, 2011-06-27 at 05:14 -0500, Ayman El-Khashab wrote: > > I took care of that in my patch. Basically it let the > > system go to gen-2 speeds and negotiate down. > > [marri] Great thx. > > Ok, so I am back from doing whatever it is that I do. Shall > I go ahead and take a stab at making a n

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-06-27 Thread Ayman El-Khashab
On Tue, May 31, 2011 at 02:27:19PM -0700, Tirumala Marri wrote: > Not sure how I would know -- But with my eiger kit, I got a > cd from amcc that had a patched 2.6.30 or something kernel > in it to support the 460SX. The pci code was basically > subverted by adding a "port->link=1" at the very en

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-31 Thread Tirumala Marri
Not sure how I would know -- But with my eiger kit, I got a cd from amcc that had a patched 2.6.30 or something kernel in it to support the 460SX. The pci code was basically subverted by adding a "port->link=1" at the very end of the link check to always force it to succeed. However this code ne

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-31 Thread Tirumala Marri
The interesting question of course is whether that 460SX stuff is the same as what we're using internally :-) [marri] Sometimes open-source and internal releases may not be the same Because of open-source standards. Can we fix that ? [marri] Sure I will take a look at it. _

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-27 Thread Benjamin Herrenschmidt
On Fri, 2011-05-27 at 11:51 -0500, Ayman El-Khashab wrote: > On Tue, May 24, 2011 at 01:40:12PM +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2011-05-12 at 11:16 -0700, Tirumala Marri wrote: > > > > The register above > > > PECFGn_DLLSTA is actually in the PCIe configuration space so > > > we

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-27 Thread Ayman El-Khashab
On Tue, May 24, 2011 at 01:40:12PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2011-05-12 at 11:16 -0700, Tirumala Marri wrote: > > The register above > > PECFGn_DLLSTA is actually in the PCIe configuration space so > > we would have to map that in to be able to read that > > register during t

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-23 Thread Benjamin Herrenschmidt
On Thu, 2011-05-12 at 11:16 -0700, Tirumala Marri wrote: > So what is the best way to handle this? It appears (based > on the comments of others and my own experience) that there > is no DCR that exists and behaves the way that previous SOCs > behaved to give us the link status? The register ab

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-12 Thread Tirumala Marri
So what is the best way to handle this? It appears (based on the comments of others and my own experience) that there is no DCR that exists and behaves the way that previous SOCs behaved to give us the link status? The register above PECFGn_DLLSTA is actually in the PCIe configuration space so we

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-09 Thread Ayman El-Khashab
On Thu, May 05, 2011 at 09:44:27AM -0700, Tirumala Marri wrote: > > > > Also, the patch removes the code for waiting for the link to be up with > > a comment "What DCR has the link status on the 460SX?". Please fix that > > (Tirumala, can you provide the missing information ?) > > > > It is not on

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-05 Thread Tirumala Marri
> > Also, the patch removes the code for waiting for the link to be up with > a comment "What DCR has the link status on the 460SX?". Please fix that > (Tirumala, can you provide the missing information ?) > It is not one register. Here is the flow for Gen-1. 1. PECFGn_DLLSTA[3] will be asserted w

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-05-03 Thread Benjamin Herrenschmidt
On Sat, 2011-04-30 at 06:37 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2011-04-29 at 12:02 -0500, Ayman El-Khashab wrote: > > On Tue, Apr 12, 2011 at 07:09:49PM -0700, Tirumala Marri wrote: > > > You originally submitted the support for 460ex. Can you chime in (and > > > review Ayman patch) ple

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-30 Thread Tirumala Marri
I'm tempted to put it in if Tirumala doesn't get to review it asap. [Marri] Sorry for the late response. I don't see any issue with changes, please go ahead. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/lin

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-29 Thread Benjamin Herrenschmidt
On Fri, 2011-04-29 at 12:02 -0500, Ayman El-Khashab wrote: > On Tue, Apr 12, 2011 at 07:09:49PM -0700, Tirumala Marri wrote: > > You originally submitted the support for 460ex. Can you chime in (and > > review Ayman patch) please ? > > > > [Marri] Ben sure I will review it and send you my feedback

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-29 Thread Ayman El-Khashab
On Tue, Apr 12, 2011 at 07:09:49PM -0700, Tirumala Marri wrote: > You originally submitted the support for 460ex. Can you chime in (and > review Ayman patch) please ? > > [Marri] Ben sure I will review it and send you my feedback in couple of > days. Is there any update on this patch? Any commen

RE: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-12 Thread Tirumala Marri
You originally submitted the support for 460ex. Can you chime in (and review Ayman patch) please ? [Marri] Ben sure I will review it and send you my feedback in couple of days. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-08 Thread Benjamin Herrenschmidt
On Fri, 2011-04-08 at 13:22 -0500, Ayman El-Khashab wrote: > From: Ayman El-Khashab > > This patch is to fix the PCIe on the 460SX CPU. As far as I can tell, > the 460SX must be using a different core than the previous 4xx SOCs. > The registers aren't the same and it appears DCRs that existed on

[PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX

2011-04-08 Thread Ayman El-Khashab
From: Ayman El-Khashab This patch is to fix the PCIe on the 460SX CPU. As far as I can tell, the 460SX must be using a different core than the previous 4xx SOCs. The registers aren't the same and it appears DCRs that existed on previous parts don't exist on this one. Perhaps somebody from AMCC