Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-27 Thread Andy Shevchenko
On Sat, Nov 25, 2023 at 03:47:41AM +0300, George Stark wrote: > On 11/24/23 18:28, Andy Shevchenko wrote: > > On Wed, Oct 25, 2023 at 04:07:29PM +0300, George Stark wrote: > > > Lots of drivers use devm_led_classdev_register() to register their led > > > objects > > > and let the kernel free

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-25 Thread Jonathan Cameron
On Sat, 25 Nov 2023 03:47:41 +0300 George Stark wrote: > Hello Andy > > Thanks for the review. > > On 11/24/23 18:28, Andy Shevchenko wrote: > > On Wed, Oct 25, 2023 at 04:07:29PM +0300, George Stark wrote: > >> Lots of drivers use devm_led_classdev_register() to register their led > >>

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-24 Thread George Stark
Hello Andy Thanks for the review. On 11/24/23 18:28, Andy Shevchenko wrote: On Wed, Oct 25, 2023 at 04:07:29PM +0300, George Stark wrote: Lots of drivers use devm_led_classdev_register() to register their led objects and let the kernel free those leds at the driver's remove stage. It can lead

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-24 Thread Andy Shevchenko
On Wed, Oct 25, 2023 at 04:07:29PM +0300, George Stark wrote: > Lots of drivers use devm_led_classdev_register() to register their led objects > and let the kernel free those leds at the driver's remove stage. > It can lead to a problem due to led_classdev_unregister() > implementation calls

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-24 Thread Andy Shevchenko
On Sat, Nov 4, 2023 at 9:17 AM George Stark wrote: > > Hello Andy > > Could you please take a look at this patch series? > > I've just found your post on habr about devres API misusing and I think > this is just another case. Just had a look, sorry for the delay. By quickly reading it seems to

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-06 Thread Christophe Leroy
Le 25/10/2023 à 15:07, George Stark a écrit : > Lots of drivers use devm_led_classdev_register() to register their led objects > and let the kernel free those leds at the driver's remove stage. > It can lead to a problem due to led_classdev_unregister() > implementation calls

Re: [PATCH 0/8] devm_led_classdev_register() usage problem

2023-11-04 Thread George Stark
Hello Andy Could you please take a look at this patch series? I've just found your post on habr about devres API misusing and I think this is just another case. On 10/25/23 16:07, George Stark wrote: Lots of drivers use devm_led_classdev_register() to register their led objects and let the

[PATCH 0/8] devm_led_classdev_register() usage problem

2023-10-25 Thread George Stark
Lots of drivers use devm_led_classdev_register() to register their led objects and let the kernel free those leds at the driver's remove stage. It can lead to a problem due to led_classdev_unregister() implementation calls led_set_brightness() to turn off the led. led_set_brightness() may call one