Re: [PATCH 03/10] powerpc/xive: rename xive_poke_esb in xive_esb_read

2017-08-09 Thread David Gibson
On Wed, Aug 09, 2017 at 09:12:29AM +0200, Cédric Le Goater wrote: > On 08/09/2017 05:55 AM, David Gibson wrote: > > On Tue, Aug 08, 2017 at 10:56:13AM +0200, Cédric Le Goater wrote: > >> xive_poke_esb() is performing a load/read so it is better named as > >> xive_esb_read(). > > > > Uh, patch

Re: [PATCH 03/10] powerpc/xive: rename xive_poke_esb in xive_esb_read

2017-08-09 Thread Cédric Le Goater
On 08/09/2017 05:55 AM, David Gibson wrote: > On Tue, Aug 08, 2017 at 10:56:13AM +0200, Cédric Le Goater wrote: >> xive_poke_esb() is performing a load/read so it is better named as >> xive_esb_read(). > > Uh, patch seems to mismatch the comment here, calling it > xive_peek_esb() instead. euh

Re: [PATCH 03/10] powerpc/xive: rename xive_poke_esb in xive_esb_read

2017-08-08 Thread David Gibson
On Tue, Aug 08, 2017 at 10:56:13AM +0200, Cédric Le Goater wrote: > xive_poke_esb() is performing a load/read so it is better named as > xive_esb_read(). Uh, patch seems to mismatch the comment here, calling it xive_peek_esb() instead. Does reading the ESB had a side effect on the hardware? If

[PATCH 03/10] powerpc/xive: rename xive_poke_esb in xive_esb_read

2017-08-08 Thread Cédric Le Goater
xive_poke_esb() is performing a load/read so it is better named as xive_esb_read(). Also introduce a XIVE_ESB_LOAD_EOI read when EOI'ing LSI interrupts. Signed-off-by: Cédric Le Goater --- arch/powerpc/sysdev/xive/common.c | 20 ++-- 1 file changed, 10