Re: [PATCH 03/13] livepatch: refactor klp_init_object

2021-01-28 Thread Christoph Hellwig
On Thu, Jan 28, 2021 at 05:22:40PM +0100, Christoph Hellwig wrote: > > We need to either update the function description or keep this check. > > > > I prefer to keep the check. The function does the right thing also > > for the object "vmlinux". Also the livepatch code includes many > > similar pa

Re: [PATCH 03/13] livepatch: refactor klp_init_object

2021-01-28 Thread Christoph Hellwig
On Wed, Jan 27, 2021 at 01:58:21PM +0100, Petr Mladek wrote: > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -54,9 +54,6 @@ static void klp_find_object_module(struct klp_object *obj) > > { > > struct module *mod; > > > > - if (!klp_is_module(obj)) > > -

[PATCH 03/13] livepatch: refactor klp_init_object

2021-01-21 Thread Christoph Hellwig
Merge three calls to klp_is_module (including one hidden inside klp_find_object_module) into a single one to simplify the code a bit. Signed-off-by: Christoph Hellwig --- kernel/livepatch/core.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/kernel/livepat