Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:55 AM, Roman Fietze wrote: > On Monday 11 January 2010 20:21:22 Grant Likely wrote: >> Why is the list head being removed? > > Not used at all, except in initialization? > > Of course a seperate patch would have been needed. For the record, I put the list_head in when w

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:55 AM, Roman Fietze wrote: > Hello Grant, > > On Monday 11 January 2010 20:21:22 Grant Likely wrote: > >> Unrelated whitespace change? > > My fault, as with some other white space changes. My Emacs is > configured using some older setup found in a 2.4 > Documentation/Cod

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-11 Thread Roman Fietze
Hello Grant, On Monday 11 January 2010 20:21:22 Grant Likely wrote: > Unrelated whitespace change? My fault, as with some other white space changes. My Emacs is configured using some older setup found in a 2.4 Documentation/CodingStyle. Before saving a file my spine is used to reformat the whole

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-11 Thread Wolfgang Denk
Dear Grant Likely, In message you wrote: > > > /* mpc52xx_lpbfifo.c */ > > #define MPC52XX_LPBFIFO_FLAG_READ (0) > > -#define MPC52XX_LPBFIFO_FLAG_WRITE (1<<0) > > -#define MPC52XX_LPBFIFO_FLAG_NO_INCREMENT (1<<1) > > -#define MPC52XX_LPBFIFO_FLAG_NO_DMA

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-11 Thread Grant Likely
On Tue, Dec 22, 2009 at 12:00 AM, Roman Fietze wrote: > This should probably be merged with the first patch to actually use the bit definitions. More comments below. > Signed-off-by: Roman Fietze > --- >  arch/powerpc/include/asm/mpc52xx.h |   40 +++ >  1 files

[PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2009-12-21 Thread Roman Fietze
Signed-off-by: Roman Fietze --- arch/powerpc/include/asm/mpc52xx.h | 40 +++ 1 files changed, 31 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/mpc52xx.h b/arch/powerpc/include/asm/mpc52xx.h index 57f8335..c659d1d 100644 --- a/arch/powerpc