Re: [PATCH 03/14] dwc/otg: Add driver framework

2011-09-02 Thread Pratyush Anand
On Fri, Sep 2, 2011 at 5:02 PM, Sebastian Andrzej Siewior wrote: > On 09/02/2011 01:17 PM, Pratyush Anand wrote: >>> >>> oh boy, oh boy. This is a huge number of module parameters. Do you >>> actually expect someone setting all of them on modprobe? And if udev is >>> faster you rmmod and modpobe a

Re: [PATCH 03/14] dwc/otg: Add driver framework

2011-09-02 Thread Sebastian Andrzej Siewior
On 09/02/2011 01:17 PM, Pratyush Anand wrote: oh boy, oh boy. This is a huge number of module parameters. Do you actually expect someone setting all of them on modprobe? And if udev is faster you rmmod and modpobe again, right? The clever ones would enter it somewhere in modprobe.conf or so. Anyw

Re: [PATCH 03/14] dwc/otg: Add driver framework

2011-09-02 Thread Pratyush Anand
On Wed, Aug 31, 2011 at 12:49 PM, Sebastian Andrzej Siewior wrote: > * Pratyush Anand | 2011-08-30 17:27:50 [+0530]: > >>diff --git a/drivers/usb/dwc/apmppc.c b/drivers/usb/dwc/apmppc.c >>new file mode 100644 >>index 000..80ea274 >>--- /dev/null >>+++ b/drivers/usb/dwc/apmppc.c >>@@ -0,0 +1,43

Re: [PATCH 03/14] dwc/otg: Add driver framework

2011-08-31 Thread Sebastian Andrzej Siewior
* Pratyush Anand | 2011-08-30 17:27:50 [+0530]: >diff --git a/drivers/usb/dwc/apmppc.c b/drivers/usb/dwc/apmppc.c >new file mode 100644 >index 000..80ea274 >--- /dev/null >+++ b/drivers/usb/dwc/apmppc.c >@@ -0,0 +1,436 @@ >+/* >+ * DesignWare HS OTG controller driver >+ * Copyright (C) 2006 Sy

[PATCH 03/14] dwc/otg: Add driver framework

2011-08-30 Thread Pratyush Anand
From: Tirumala Marri Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld Signed-off-by: Pratyush Anand --- drivers/usb/dwc/apmppc.c | 436 +++