Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-10-02 Thread Peter Korsgaard
Grant == Grant Likely [EMAIL PROTECTED] writes: Grant From: Grant Likely [EMAIL PROTECTED] Grant Signed-off-by: Grant Likely [EMAIL PROTECTED] Grant Acked-by: John Williams [EMAIL PROTECTED] Huh? This seems a bit confused. Microblaze is big endian and out_be32 is only defined in

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-10-02 Thread Grant Likely
On 10/2/07, Peter Korsgaard [EMAIL PROTECTED] wrote: The uartlite driver is ofcause primarily used to drive Xilinx OPB_Uartlite IP blocks, but that's not the only use - E.G. we are using another simple UART with the same hardware interface but sitting on a 16bit bus. With the current driver

[PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Grant Likely
From: Grant Likely [EMAIL PROTECTED] Signed-off-by: Grant Likely [EMAIL PROTECTED] Acked-by: John Williams [EMAIL PROTECTED] --- arch/ppc/syslib/virtex_devices.c |2 +- drivers/serial/uartlite.c| 32 2 files changed, 17 insertions(+), 17

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Olof Johansson
On Fri, Sep 28, 2007 at 12:17:13PM -0600, Grant Likely wrote: From: Grant Likely [EMAIL PROTECTED] Signed-off-by: Grant Likely [EMAIL PROTECTED] Acked-by: John Williams [EMAIL PROTECTED] --- arch/ppc/syslib/virtex_devices.c |2 +- drivers/serial/uartlite.c| 32

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Grant Likely
On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: On Fri, Sep 28, 2007 at 12:17:13PM -0600, Grant Likely wrote: From: Grant Likely [EMAIL PROTECTED] Signed-off-by: Grant Likely [EMAIL PROTECTED] Acked-by: John Williams [EMAIL PROTECTED] --- arch/ppc/syslib/virtex_devices.c |2

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Olof Johansson
On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote: On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: Hmm, I see the start changed, and you're now reading/writing a full 32-bit word instead of individual bytes. Still, looks a little fishy to me. Wouldn't it be more appropriate

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Grant Likely
On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote: On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: Also, I'm not sure you need to cast port-membase to void*, do you? The math will still be right since it's declared as char

Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze)

2007-09-28 Thread Grant Likely
On 9/28/07, Grant Likely [EMAIL PROTECTED] wrote: On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote: On 9/28/07, Olof Johansson [EMAIL PROTECTED] wrote: Also, I'm not sure you need to cast port-membase to void*, do you? The