Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-31 Thread Srikar Dronamraju
> mm, vmscan: Only allocate and reclaim from zones with pages managed by the > buddy allocator > > Firmware Assisted Dump (FA_DUMP) on ppc64 reserves substantial amounts > of memory when booting a secondary kernel. Srikar Dronamraju reported that > multiple nodes may have no memory managed by

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-31 Thread Mel Gorman
On Wed, Aug 31, 2016 at 01:09:33PM +0200, Michal Hocko wrote: > > We cannot just convert populated_zone() as many existing users really > > need to check for present_pages. This patch introduces a managed_zone() > > helper and uses it in the few cases where it is critical that the check > > is

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-31 Thread Michal Hocko
On Wed 31-08-16 09:49:42, Mel Gorman wrote: > On Wed, Aug 31, 2016 at 11:39:59AM +0530, Srikar Dronamraju wrote: > > This indeed fixes the problem. > > Please add my > > Tested-by: Srikar Dronamraju > > > > Ok, thanks. Unfortunately we cannot do a wide conversion

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-31 Thread Mel Gorman
On Wed, Aug 31, 2016 at 11:39:59AM +0530, Srikar Dronamraju wrote: > This indeed fixes the problem. > Please add my > Tested-by: Srikar Dronamraju > Ok, thanks. Unfortunately we cannot do a wide conversion like this because some users of populated_zone() really meant

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-31 Thread Srikar Dronamraju
> > The trigger is memblock_reserve() for the complete node memory. And > > this is exactly what FA_DUMP does. Here again the node has memory but > > its all reserved so there is no free memory in the node. > > > > Did you mean populated_zone() when you said zone_populated or have I > >

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-30 Thread Mel Gorman
On Tue, Aug 30, 2016 at 07:55:08PM +0530, Srikar Dronamraju wrote: > > > > > > This patch seems to hurt FA_DUMP functionality. This behaviour is not > > > seen on v4.7 but only after this patch. > > > > > > So when a kernel on a multinode machine with memblock_reserve() such > > > that most of

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-30 Thread Srikar Dronamraju
> > > > This patch seems to hurt FA_DUMP functionality. This behaviour is not > > seen on v4.7 but only after this patch. > > > > So when a kernel on a multinode machine with memblock_reserve() such > > that most of the nodes have zero available memory, kswapd seems to be > > consuming 100% of

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-30 Thread Mel Gorman
On Mon, Aug 29, 2016 at 03:08:44PM +0530, Srikar Dronamraju wrote: > > Patch "mm: vmscan: Begin reclaiming pages on a per-node basis" started > > thinking of reclaim in terms of nodes but kswapd is still zone-centric. This > > patch gets rid of many of the node-based versus zone-based decisions. >

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

2016-08-29 Thread Srikar Dronamraju
> Patch "mm: vmscan: Begin reclaiming pages on a per-node basis" started > thinking of reclaim in terms of nodes but kswapd is still zone-centric. This > patch gets rid of many of the node-based versus zone-based decisions. > > o A node is considered balanced when any eligible lower zone is