On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
Je
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
> --
On Jul 18, 2007, at 02:00, pradeep singh wrote:
> On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote:
>> - if (err)
>> + if (err < 0)
>> return err;
>
> but would that mean, if phy_read returns > 0 it is a success?
Yes. phy_read() returns a 3
On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
>
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
---
I made a really stupid mistake in the 4 patches I sent out,
