Hi Scott,
> On Sat, 18 Sep 2010 14:22:12 -0400
> Josh Boyer wrote:
>
>> Capitalizing? The patch you posted that uses this symbol is for a GPL
>> driver so you gain or lose nothing by having this symbol be
>> EXPORT_SYMBOL_GPL. Are you somehow advocating and getting some sort
>> of gain by allow
On Sat, 18 Sep 2010 14:22:12 -0400
Josh Boyer wrote:
> Capitalizing? The patch you posted that uses this symbol is for a GPL
> driver so you gain or lose nothing by having this symbol be
> EXPORT_SYMBOL_GPL. Are you somehow advocating and getting some sort
> of gain by allowing non-GPL modules?
On Sat, 2010-09-18 at 10:34 -0500, Kumar Gala wrote:
> On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote:
>
> > On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt"
> > wrote:
> >
> >> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
> >>> I don't see any reason to limit it to GPL driv
Josh Boyer wrote:
> This is a new symbol being exported, not
> one that has been exported for years.
Except that Ben says that I should change ppc_proc_freq from EXPORT_SYMBOL to
EXPORT_SYMBOL_GPL as well. In a sense, we're in a catch-22. We have three
choices:
1. We *arbitrarily* change ppc_
Josh Boyer wrote:
> It is not, in my opinion, about what is technically possible and what
> isn't. The kernel is licensed under the GPL. This is a Linux kernel
> only symbol. One would be hard pressed to claim they have a driver
> that wasn't written for Linux that happens to need that symbol.
On Sep 18, 2010, at 11:56 AM, Josh Boyer wrote:
> On Sat, Sep 18, 2010 at 11:34 AM, Kumar Gala wrote:
>>
>> On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote:
>>
>>> On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt"
>>> wrote:
>>>
On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi w
On Sat, Sep 18, 2010 at 1:55 PM, Tabi Timur-B04825 wrote:
> Josh Boyer wrote:
>> This is a new symbol being exported, not
>> one that has been exported for years.
>
> Except that Ben says that I should change ppc_proc_freq from EXPORT_SYMBOL
> to
> EXPORT_SYMBOL_GPL as well. In a sense, we're in
On Sat, Sep 18, 2010 at 1:36 PM, Tabi Timur-B04825 wrote:
> Josh Boyer wrote:
>> It is not, in my opinion, about what is technically possible and what
>> isn't. The kernel is licensed under the GPL. This is a Linux kernel
>> only symbol. One would be hard pressed to claim they have a driver
>>
On Sat, Sep 18, 2010 at 11:34 AM, Kumar Gala wrote:
>
> On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote:
>
>> On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt"
>> wrote:
>>
>>> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
I don't see any reason to limit it to GPL drivers.
On Sat, Sep 18, 2010 at 5:34 PM, Kumar Gala wrote:
> I don't think either of these should be EXPORT_SYMBOL_GPL. Why shouldn't a
> binary module be allowed to know these frequencies? My view is why preclude
> anyone from using this how they want. If they want to live in the gray area
> so be
On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote:
> On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt"
> wrote:
>
>> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
>>> I don't see any reason to limit it to GPL drivers. Not only that, but
>>> then we'll have this:
>>
>> I do
>
On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt"
wrote:
> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
>> I don't see any reason to limit it to GPL drivers. Not only that, but
>> then we'll have this:
>
> I do
Can you elaborate on that, or are you just going to pull rank on me?
On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
> I don't see any reason to limit it to GPL drivers. Not only that, but
> then we'll have this:
I do
> EXPORT_SYMBOL(ppc_proc_freq);
> EXPORT_SYMBOL_GPL(ppc_tb_freq);
>
> That just looks dumb.
Right, so send a patch to fix the first one too
On Fri, Sep 17, 2010 at 7:38 PM, Josh Boyer wrote:
>> unsigned long ppc_proc_freq;
>> EXPORT_SYMBOL(ppc_proc_freq);
>> unsigned long ppc_tb_freq;
>> +EXPORT_SYMBOL(ppc_tb_freq);
>
> EXPORT_SYMBOL_GPL probably, no?
I don't see any reason to limit it to GPL drivers. Not only that, but
then we'
On Fri, Sep 17, 2010 at 6:53 PM, Timur Tabi wrote:
> Export the global variable 'ppc_tb_freq', so that modules (like the Book-E
> watchdog driver) can use it.
>
> Signed-off-by: Timur Tabi
> ---
>
> This export is necessary for the Book-E watchdog driver to be compiled as a
> module. Since ppc_p
Export the global variable 'ppc_tb_freq', so that modules (like the Book-E
watchdog driver) can use it.
Signed-off-by: Timur Tabi
---
This export is necessary for the Book-E watchdog driver to be compiled as a
module. Since ppc_proc_freq is already exported, I figured it's okay for
ppc_tb_freq
16 matches
Mail list logo
