Re: [PATCH 1/2] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index

2013-05-20 Thread Benjamin Herrenschmidt
On Mon, 2013-05-20 at 09:57 +0530, Aneesh Kumar K.V wrote: Michael Neuling mi...@neuling.org writes: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use smb_rmb when looking at hpte slot array. Otherwise we

Re: [PATCH 1/2] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index

2013-05-20 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Mon, 2013-05-20 at 09:57 +0530, Aneesh Kumar K.V wrote: Michael Neuling mi...@neuling.org writes: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use

Re: [PATCH 1/2] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index

2013-05-19 Thread Michael Neuling
Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use smb_rmb when looking at hpte slot array. Otherwise we could reorder the hpte_slot array load bfore even we marked the pmd trans huge. Does this need to go back into

Re: [PATCH 1/2] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index

2013-05-19 Thread Aneesh Kumar K.V
Michael Neuling mi...@neuling.org writes: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use smb_rmb when looking at hpte slot array. Otherwise we could reorder the hpte_slot array load bfore even we marked the pmd

[PATCH 1/2] powerpc: use smp_rmb when looking at deposisted pgtable to store hash index

2013-05-17 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use smb_rmb when looking at hpte slot array. Otherwise we could reorder the hpte_slot array load bfore even we marked the pmd trans huge. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com ---