On Fri, Mar 28, 2008 at 12:30:29PM -0500, Scott Wood wrote:
York Sun wrote:
+static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
+ unsigned long arg)
+{
+struct mfb_info *mfbi = info-par;
+struct diu_ad *ad = mfbi-ad;
+struct mfb_chroma_key ck;
+
Scott Wood wrote:
...but not anywhere else. All user pointers should have a __user
annotation.
Even in a typecast?
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
Timur Tabi wrote:
Scott Wood wrote:
...but not anywhere else. All user pointers should have a __user
annotation.
Even in a typecast?
Yes. Otherwise, as far as sparse sees, you're passing a kernel pointer
to something expecting a user pointer.
-Scott
On Fri, 2008-03-28 at 20:48 +0300, Anton Vorontsov wrote:
+ if (copy_from_user(pix_fmt, (void __user *)arg,
+ sizeof(pix_fmt)))
OK, you fixed the cast here...
Maybe better would be to define buf at the top of this function as
void __user *buf = (void
The following features are supported:
plane 0 works as a regular frame buffer, can be accessed by /dev/fb0
plane 1 has two AOIs (area of interest), can be accessed by /dev/fb1 and
/dev/fb2
plane 2 has two AOIs, can be accessed by /dev/fb3 and /dev/fb4
Special ioctls support AOIs
All /dev/fb* can
