The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./sound/soc/codecs/wcd9335.c:5193:2-8: ERROR: missing of_node_put; acquired a 
node pointer with refcount incremented on line 5183, but without a correspon    
ding object release within this function.

Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
Cc: Liam Girdwood <lgirdw...@gmail.com>
Cc: Mark Brown <broo...@kernel.org>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <ti...@suse.com>
Cc: Srinivas Kandagatla <srinivas.kandaga...@linaro.org>
Cc: Vinod Koul <vk...@kernel.org>
Cc: Dan Carpenter <dan.carpen...@oracle.com> 
(commit_signer:1/11=9%,authored:1/11=9%)
Cc: alsa-de...@alsa-project.org
Cc: linux-ker...@vger.kernel.org
---
 sound/soc/codecs/wcd9335.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 981f88a..a04a7ce 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -5188,6 +5188,7 @@ static int wcd9335_slim_status(struct slim_device *sdev,
 
        wcd->slim = sdev;
        wcd->slim_ifc_dev = of_slim_get_device(sdev->ctrl, ifc_dev_np);
+       of_node_put(ifc_dev_np);
        if (!wcd->slim_ifc_dev) {
                dev_err(dev, "Unable to get SLIM Interface device\n");
                return -EINVAL;
-- 
2.9.5

Reply via email to