On Jan 7, 2008, at 6:03 AM, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
address comments and use new dts spec.
arch/powerpc/boot/dts/mpc8377_mds.dts | 277
+++
arch/powerpc/boot/dts/mpc8378_mds.dts | 263
+
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
Hi Leo,
comments below. I've made my comments on the first file, but they
apply to the other two also.
Cheers,
g.
[snip]
+ ranges = 0 e000 0010;
+ reg = e000 0200;
+
On 1/9/08, David Gibson [EMAIL PROTECTED] wrote:
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
+ compatible = mpc83xx_wdt;
fsl,mpc8377_wdt, fsl,mpc83xx_wdt as per generic names recommended
practice.
Uh.. that's reasonable advice, but it has
Hi Leo,
comments below. I've made my comments on the first file, but they
apply to the other two also.
Cheers,
g.
On 1/7/08, Li Yang [EMAIL PROTECTED] wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
address comments and use new dts spec.
arch/powerpc/boot/dts/mpc8377_mds.dts | 277
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
On 1/7/08, Li Yang [EMAIL PROTECTED] wrote:
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ device_type = soc;
I recommend dropping device_type and adding
On 1/8/08, Scott Wood [EMAIL PROTECTED] wrote:
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
On 1/7/08, Li Yang [EMAIL PROTECTED] wrote:
+ phy_type = utmi_wide;
fsl,phy_type please.
Again, code will break. Can we stop ambushing people submitting
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
address comments and use new dts spec.
arch/powerpc/boot/dts/mpc8377_mds.dts | 277 +++
arch/powerpc/boot/dts/mpc8378_mds.dts | 263 +
arch/powerpc/boot/dts/mpc8379_mds.dts | 291
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Tuesday, January 08, 2008 3:37 PM
To: Li Yang
Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]
Subject: Re: [PATCH 1/3] add default device trees for MPC837x
MDS board
On Jan 7, 2008, at 6:03 AM, Li Yang wrote
On Jan 7, 2008, at 6:03 AM, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
address comments and use new dts spec.
arch/powerpc/boot/dts/mpc8377_mds.dts | 277
+++
arch/powerpc/boot/dts/mpc8378_mds.dts | 263
+
