Segher, what are we missing here ?
The symbol name is misleading, and the help text is incorrect.
With those things fixed, I won't oppose the patch; it would
be nice if the logic here was cleaned up to avoid all the
double negations, but I'm not going to do it, so I won't ask
others to either.
On Tue, 2009-05-05 at 19:11 -0400, Steven Rostedt wrote:
OK, so what's the status with this patch series?
I don't want to pull it in unless I have an ack from Sam, and now
there's issues with having -fno-omit-frame-pointer. Should we add a
patch instead that simply removes that?
If we
Yeah, I agree. This needs a better description. I only know what's
going
on because I was there for the start of the discussion.
But just to be sure, this is what I think is happening.
When we add -pg to gcc, it automatically causes frame pointers to be
used.
Nope, it does no such thing.
On Tue, 2009-05-05 at 09:56 +0200, Segher Boessenkool wrote:
Yeah, I agree. This needs a better description. I only know what's
going
on because I was there for the start of the discussion.
But just to be sure, this is what I think is happening.
When we add -pg to gcc, it
When we add -pg to gcc, it automatically causes frame pointers
to be
used.
Nope, it does no such thing.
Well, mcount is expected to be able to get to not just who called
mcount, but also the parent of that function. The way mcount is
implemented does not let you do that. If mcount was the
On Tue, 2009-05-05 at 15:51 +0200, Segher Boessenkool wrote:
When we add -pg to gcc, it automatically causes frame pointers
to be
used.
Nope, it does no such thing.
Well, mcount is expected to be able to get to not just who called
mcount, but also the parent of that function.
This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless for PowerPC kernels, and also makes gcc
generate wrong code).
+++ b/arch/powerpc/Kconfig
+ select HAVE_NORMAL_FRAME_POINTER
On Sat, 2009-05-02 at 21:48 +0200, Segher Boessenkool wrote:
This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless for PowerPC kernels, and also makes gcc
generate wrong code).
This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless for PowerPC kernels, and also makes gcc
generate wrong code).
Also move ARCH_WANT_FRAME_POINTERS's help text.
Signed-off-by: Anton
On Sun, Apr 05, 2009 at 11:07:56PM +0200, Sam Ravnborg wrote:
On Fri, Mar 20, 2009 at 07:44:29PM +0300, Anton Vorontsov wrote:
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is
On Sun, 2009-04-05 at 23:07 +0200, Sam Ravnborg wrote:
4) The individual HAVE_* members should be sorted alphabetically in the arch
Kconfig file (which they seldomly are :-( )
Note, my first port of Ftrace to PPC sorted the Kconfig HAVE_* macros,
which ended up being reverted :-/
On Fri, Mar 20, 2009 at 07:44:29PM +0300, Anton Vorontsov wrote:
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless in PowerPC kernels, and also makes gcc
generate wrong code).
On Sat, 2009-03-28 at 13:48 +0300, Anton Vorontsov wrote:
On Fri, Mar 20, 2009 at 11:49:29PM -0400, Steven Rostedt wrote:
Ben,
Can you ACK this patch? Or even take it in your tree?
Benjamin, have you had a chance to look into this? Sam, could
you also take a look?
Those patches look
On Mon, Mar 30, 2009 at 09:54:50AM +1100, Benjamin Herrenschmidt wrote:
On Sat, 2009-03-28 at 13:48 +0300, Anton Vorontsov wrote:
On Fri, Mar 20, 2009 at 11:49:29PM -0400, Steven Rostedt wrote:
Ben,
Can you ACK this patch? Or even take it in your tree?
Benjamin, have you had a
On Fri, Mar 20, 2009 at 11:49:29PM -0400, Steven Rostedt wrote:
Ben,
Can you ACK this patch? Or even take it in your tree?
Benjamin, have you had a chance to look into this? Sam, could
you also take a look?
Thanks!
On Fri, 2009-03-20 at 19:44 +0300, Anton Vorontsov wrote:
This patch
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless in PowerPC kernels, and also makes gcc
generate wrong code).
Also move ARCH_WANT_FRAME_POINTERS's help text.
Signed-off-by: Anton
Ben,
Can you ACK this patch? Or even take it in your tree?
Thanks,
-- Steve
On Fri, 2009-03-20 at 19:44 +0300, Anton Vorontsov wrote:
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag
17 matches
Mail list logo
