Re: [PATCH 1/3] powerpc/powernv/pci: Reduce spam when dumping PEST

2017-05-30 Thread Andrew Donnellan
On 30/05/17 21:28, Michael Ellerman wrote: You and a few other people who are also wrong ;) Using PPC_BIT() means people have to go and dereference that macro before they can grok the code, and when they do look at the macro they go "huh, wut is this insanity". Any non-PPC person who's

Re: [PATCH 1/3] powerpc/powernv/pci: Reduce spam when dumping PEST

2017-05-30 Thread Michael Ellerman
Andrew Donnellan writes: > On 30/05/17 15:44, Russell Currey wrote: >> diff --git a/arch/powerpc/platforms/powernv/pci.c >> b/arch/powerpc/platforms/powernv/pci.c >> index 935ccb249a8a..4852ac8d0b4d 100644 >> --- a/arch/powerpc/platforms/powernv/pci.c >> +++

Re: [PATCH 1/3] powerpc/powernv/pci: Reduce spam when dumping PEST

2017-05-30 Thread Andrew Donnellan
On 30/05/17 15:44, Russell Currey wrote: Dumping the PE State Tables (PEST) can be highly verbose if a number of PEs are affected, especially in the case where the whole PHB is frozen and 512 lines get printed. Check for duplicates when dumping the PEST to reduce useless output. For example:

[PATCH 1/3] powerpc/powernv/pci: Reduce spam when dumping PEST

2017-05-29 Thread Russell Currey
Dumping the PE State Tables (PEST) can be highly verbose if a number of PEs are affected, especially in the case where the whole PHB is frozen and 512 lines get printed. Check for duplicates when dumping the PEST to reduce useless output. For example: PE[0f8] A/B: 9726