Re: [PATCH 1/3] powerpc clk.h interface for platforms

2007-09-19 Thread Domen Puncer
On 19/09/07 13:47 +1000, Paul Mackerras wrote: Domen Puncer writes: Paul, what do you say about this? Sylvain suggested it could also be integrated with define_machine interface. As it stands, your patch adds the clk_* functions on all platforms. What platforms would actually want to

Re: [PATCH 1/3] powerpc clk.h interface for platforms

2007-09-19 Thread Paul Mackerras
Domen Puncer writes: 52xx Reason for adding it to all was that EXPORT_SYMBOL's would clash if one were to add clk support for another platform. What I meant was, why aren't you using a config symbol so that we don't build it on platforms that don't need any clk support at all? Paul.

Re: [PATCH 1/3] powerpc clk.h interface for platforms

2007-09-18 Thread Paul Mackerras
Domen Puncer writes: Paul, what do you say about this? Sylvain suggested it could also be integrated with define_machine interface. As it stands, your patch adds the clk_* functions on all platforms. What platforms would actually want to use them? Paul.

Re: Generic clk.h wrappers? [Was: Re: [PATCH 1/3] powerpc clk.h interface for platforms]

2007-08-01 Thread Christoph Hellwig
On Wed, Aug 01, 2007 at 09:28:07AM +0200, Domen Puncer wrote: It doesn't make any assumption on struct clk, it's just a wrapper around functions from clk.h. Point of this patch was to abstract exported functions, since arch/powerpc/ can support multiple platfroms in one binary. So...

Re: [PATCH 1/3] powerpc clk.h interface for platforms

2007-07-13 Thread Domen Puncer
On 11/07/07 21:34 +0100, Russell King wrote: On Wed, Jul 11, 2007 at 10:02:54AM -0700, David Brownell wrote: On Wednesday 11 July 2007, Christoph Hellwig wrote: On Wed, Jul 11, 2007 at 08:56:58AM -0700, David Brownell wrote: Umm, this is about the fifth almost identical implementation

Re: [PATCH 1/3] powerpc clk.h interface for platforms

2007-07-11 Thread Russell King
On Wed, Jul 11, 2007 at 10:02:54AM -0700, David Brownell wrote: On Wednesday 11 July 2007, Christoph Hellwig wrote: On Wed, Jul 11, 2007 at 08:56:58AM -0700, David Brownell wrote: Umm, this is about the fifth almost identical implementation of the clk_ functions. Please, please put it