Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-29 Thread Peter Zijlstra
On Tue, Oct 29, 2013 at 09:00:52AM +0530, Preeti U Murthy wrote: > > Oh nice, that gets rid of the multiple atomics, and it nicely splits > > this nohz logic into per topology groups -- now if only we could split > > the rest too :-) > > I am sorry, I don't get you here. By the 'rest', do you refe

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-28 Thread Preeti U Murthy
Hi Peter, On 10/28/2013 07:20 PM, Peter Zijlstra wrote: > On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote: >> kernel/sched/core.c |5 + >> kernel/sched/fair.c | 38 -- >> kernel/sched/sched.h |1 + >> 3 files changed, 26 insertio

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-28 Thread Peter Zijlstra
On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote: > kernel/sched/core.c |5 + > kernel/sched/fair.c | 38 -- > kernel/sched/sched.h |1 + > 3 files changed, 26 insertions(+), 18 deletions(-) > > diff --git a/kernel/sched/core.c b/

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-24 Thread Preeti U Murthy
Hi Vincent, I have addressed your comments and below is the fresh patch. This patch applies on PATCH 2/3 posted in this thread. Regards Preeti U Murthy sched:Remove un-necessary iterations over sched domains to update/query nr_busy_cpus From: Preeti U Murthy nr_busy_cpus parameter is used b

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-23 Thread Vincent Guittot
Hi Preeti On 23 October 2013 11:50, Preeti U Murthy wrote: > Hi Peter > > On 10/23/2013 03:41 AM, Peter Zijlstra wrote: >> This nohz stuff really needs to be re-thought and made more scalable -- >> its a royal pain :/ > > Why not do something like the below instead? It does the following. > > Th

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-23 Thread Preeti U Murthy
Hi Peter On 10/23/2013 03:41 AM, Peter Zijlstra wrote: > This nohz stuff really needs to be re-thought and made more scalable -- > its a royal pain :/ Why not do something like the below instead? It does the following. This patch introduces sd_busy just like your suggested patch, except that it

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Preeti U Murthy
On 10/23/2013 09:30 AM, Preeti U Murthy wrote: > Hi Peter, > > On 10/23/2013 03:41 AM, Peter Zijlstra wrote: >> On Mon, Oct 21, 2013 at 05:14:42PM +0530, Vaidyanathan Srinivasan wrote: >>> kernel/sched/fair.c | 19 +-- >>> 1 file changed, 13 insertions(+), 6 deletions(-) >>> >>>

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Preeti U Murthy
Hi Peter, On 10/23/2013 03:41 AM, Peter Zijlstra wrote: > On Mon, Oct 21, 2013 at 05:14:42PM +0530, Vaidyanathan Srinivasan wrote: >> kernel/sched/fair.c | 19 +-- >> 1 file changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >>

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Peter Zijlstra
On Mon, Oct 21, 2013 at 05:14:42PM +0530, Vaidyanathan Srinivasan wrote: > kernel/sched/fair.c | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7c70201..12f0eab 100644 > --- a/kernel/sched/fair.c > ++

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Preeti U Murthy
Hi Kamalesh, On 10/22/2013 08:05 PM, Kamalesh Babulal wrote: > * Vaidyanathan Srinivasan [2013-10-21 17:14:42]: > >> for_each_domain(cpu, sd) { >> -struct sched_group *sg = sd->groups; >> -struct sched_group_power *sgp = sg->sgp; >> -int nr_busy = atomic_

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Kamalesh Babulal
* Vaidyanathan Srinivasan [2013-10-21 17:14:42]: > for_each_domain(cpu, sd) { > - struct sched_group *sg = sd->groups; > - struct sched_group_power *sgp = sg->sgp; > - int nr_busy = atomic_read(&sgp->nr_busy_cpus); > - > - if (sd->flags & SD_S

[PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-21 Thread Vaidyanathan Srinivasan
From: Preeti U Murthy In nohz_kick_needed() there are checks around the flags SD_SHARE_PKG_RESOURCES which decide to initiate nohz_balance if the domains with this flag set have more than one cpu busy. Therefore at every domain, a check has to be made on nr_busy of that domain. This means the sum