Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-19 Thread Will Deacon
On Fri, Apr 19, 2024 at 07:06:00AM -0700, Sean Christopherson wrote: > On Fri, Apr 19, 2024, Will Deacon wrote: > > On Mon, Apr 15, 2024 at 07:31:23AM -0700, Sean Christopherson wrote: > > > On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: > > > Oof. I completely missed that "cpu_mitigations"

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-19 Thread Sean Christopherson
On Fri, Apr 19, 2024, Will Deacon wrote: > On Mon, Apr 15, 2024 at 07:31:23AM -0700, Sean Christopherson wrote: > > On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: > > Oof. I completely missed that "cpu_mitigations" wasn't x86-only. I can't > > think > > of better solution than an on-by-default

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-19 Thread Will Deacon
On Mon, Apr 15, 2024 at 07:31:23AM -0700, Sean Christopherson wrote: > On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: > > On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman > > wrote: > > > Michael Ellerman writes: > > > > Stephen Rothwell writes: > > > ... > > > >> On Tue, 9 Apr 2024

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-16 Thread Michael Ellerman
Sean Christopherson writes: > On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: >> On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman >> wrote: >> > Michael Ellerman writes: >> > > Stephen Rothwell writes: >> > ... >> > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson >> > >> wrote:

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-15 Thread Sean Christopherson
On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: > Hi Michael, > > On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman wrote: > > Michael Ellerman writes: > > > Stephen Rothwell writes: > > ... > > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > > >> wrote: > > ... > > >>> diff

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-15 Thread Geert Uytterhoeven
Hi Michael, On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman wrote: > Michael Ellerman writes: > > Stephen Rothwell writes: > ... > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > >> wrote: > ... > >>> diff --git a/kernel/cpu.c b/kernel/cpu.c > >>> index

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-14 Thread Stephen Rothwell
Hi all, On Sat, 13 Apr 2024 19:38:47 +1000 Michael Ellerman wrote: > > Michael Ellerman writes: > > Stephen Rothwell writes: > ... > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > >> wrote: > ... > >>> diff --git a/kernel/cpu.c b/kernel/cpu.c > >>> index

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-13 Thread Michael Ellerman
Michael Ellerman writes: > Stephen Rothwell writes: ... >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson >> wrote: ... >>> diff --git a/kernel/cpu.c b/kernel/cpu.c >>> index 8f6affd051f7..07ad53b7f119 100644 >>> --- a/kernel/cpu.c >>> +++ b/kernel/cpu.c >>> @@ -3207,7 +3207,8 @@ enum

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-13 Thread Michael Ellerman
Stephen Rothwell writes: > Hi Sean, > > I noticed this commit in linux-next. > > On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > wrote: >> >> Initialize cpu_mitigations to CPU_MITIGATIONS_OFF if the kernel is built >> with CONFIG_SPECULATION_MITIGATIONS=n, as the help text quite

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-12 Thread Stephen Rothwell
Hi Sean, I noticed this commit in linux-next. On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson wrote: > > Initialize cpu_mitigations to CPU_MITIGATIONS_OFF if the kernel is built > with CONFIG_SPECULATION_MITIGATIONS=n, as the help text quite clearly > states that disabling