Re: [PATCH 1 4/4] PCI: rcar: Use of_device_get_match_data() to simplify probe

2017-02-02 Thread Simon Horman
On Tue, Jan 31, 2017 at 02:20:20PM -0600, Bjorn Helgaas wrote: > This is a DT-only driver, so the only way to call rcar_pcie_probe() is to > match an entry in rcar_pcie_of_match[], so of_id cannot be NULL. > > Furthermore, of_id->data can only be NULL if an rcar_pcie_of_match[] entry > has a NULL

[PATCH 1 4/4] PCI: rcar: Use of_device_get_match_data() to simplify probe

2017-01-31 Thread Bjorn Helgaas
This is a DT-only driver, so the only way to call rcar_pcie_probe() is to match an entry in rcar_pcie_of_match[], so of_id cannot be NULL. Furthermore, of_id->data can only be NULL if an rcar_pcie_of_match[] entry has a NULL .data member. That's a driver defect, and we don't want to return -EINVA