On 7/27/08, Grant Likely <[EMAIL PROTECTED]> wrote:
> On Sun, Jul 27, 2008 at 12:44 AM, Jon Smirl <[EMAIL PROTECTED]> wrote:
> > On 7/26/08, Grant Likely <[EMAIL PROTECTED]> wrote:
> >> On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
> >>
> >> > Allow a custom ASOC machine driver wit
On Sun, Jul 27, 2008 at 12:44 AM, Jon Smirl <[EMAIL PROTECTED]> wrote:
> On 7/26/08, Grant Likely <[EMAIL PROTECTED]> wrote:
>> On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
>>
>> > Allow a custom ASOC machine driver with soc-of-simple
>> >
>> > Signed-off-by: Jon Smirl <[EMAIL PROTE
On 7/26/08, Grant Likely <[EMAIL PROTECTED]> wrote:
> On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
>
> > Allow a custom ASOC machine driver with soc-of-simple
> >
> > Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
>
>
> Sorry I didn't respond earlier. OLS kept me pretty distracted.
>
On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
> Allow a custom ASOC machine driver with soc-of-simple
>
> Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
Sorry I didn't respond earlier. OLS kept me pretty distracted.
Need a more detailed comment block about how your changing things an
On Wed, Jul 23, 2008 at 04:14:32PM +0100, Mark Brown wrote:
> On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote:
> > On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
>
> > > ...this doesn't just allow a custom machine driver, it requires that
> > > something configures at least the machi
On Wed, Jul 23, 2008 at 11:16:17AM -0400, Jon Smirl wrote:
> On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
> > I'd also expect something to handle the existing user.
> This is a modification to Grant's new driver. Grant is the only other user.
Right, hence my use of the singular : ) . Sinc
On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
> On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote:
> > On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
>
>
> > > ...this doesn't just allow a custom machine driver, it requires that
> > > something configures at least the machine name
On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote:
> On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
> > ...this doesn't just allow a custom machine driver, it requires that
> > something configures at least the machine name. That's not a problem
> > from the ASoC point of view but po
On 7/23/08, Mark Brown <[EMAIL PROTECTED]> wrote:
> On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
>
> > Allow a custom ASOC machine driver with soc-of-simple
>
>
> As with the clocking configuration: this looks fine from an ASoC point
> of view but please fix the checkpatch warnings.
On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
> Allow a custom ASOC machine driver with soc-of-simple
As with the clocking configuration: this looks fine from an ASoC point
of view but please fix the checkpatch warnings. However...
> /* Only register the device if both the co
Hi John,
On Tue, 22 Jul 2008 19:53:51 -0400 Jon Smirl <[EMAIL PROTECTED]> wrote:
>
> +static struct snd_soc_ops *machine_ops = NULL;
> +static char *machine_name = NULL;
You don't need these initialisations.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.o
Allow a custom ASOC machine driver with soc-of-simple
Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
---
include/sound/soc-of-simple.h |2 ++
sound/soc/fsl/soc-of-simple.c | 26 +-
2 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/include/sound/soc-of-si
12 matches
Mail list logo
