On Wed, May 21, 2008 at 04:28:51PM -0500, Nate Case wrote:
This adds support for hardware configurations that don't match the
chip default register settings (e.g., 16-bit data bus, DACK and
DREQ pulled down instead of up, analog overcurrent mode).
These settings are passed in via the OF
* Nate Case | 2008-05-21 16:28:51 [-0500]:
This adds support for hardware configurations that don't match the
chip default register settings (e.g., 16-bit data bus, DACK and
DREQ pulled down instead of up, analog overcurrent mode).
Nice patch. A few comments inline.
These settings are passed in
On Thu, 2008-05-22 at 17:35 +0200, Sebastian Siewior wrote:
If you don't mind, I would prefer having ISP1760_FLAG_BUS_WIDTH_32 and
or conditionally HW_DATA_BUS_32BIT.
It doesn't matter much to me -- I just reasoned that a 32-bit bus width
was the norm since it's the hardware default and so
This adds support for hardware configurations that don't match the
chip default register settings (e.g., 16-bit data bus, DACK and
DREQ pulled down instead of up, analog overcurrent mode).
These settings are passed in via the OF device tree. The PCI
interface still assumes the same default
