Re: [PATCH 2/2] powerpc/eeh: Reworked eeh_pe_bus_get()

2016-02-08 Thread Gavin Shan
On Mon, Feb 08, 2016 at 04:35:19PM +1100, Gavin Shan wrote: >The original implementation is ugly: unnecessary if statements and >"out" tag. This reworks the function to avoid above weaknesses. No >functional changes introduced. > >Signed-off-by: Gavin Shan Michael, please ignore this one now beca

Re: [PATCH 2/2] powerpc/eeh: Reworked eeh_pe_bus_get()

2016-02-07 Thread Andrew Donnellan
On 08/02/16 16:35, Gavin Shan wrote: The original implementation is ugly: unnecessary if statements and "out" tag. This reworks the function to avoid above weaknesses. No functional changes introduced. Signed-off-by: Gavin Shan This is definitely a lot nicer to read and doesn't appear to have

[PATCH 2/2] powerpc/eeh: Reworked eeh_pe_bus_get()

2016-02-07 Thread Gavin Shan
The original implementation is ugly: unnecessary if statements and "out" tag. This reworks the function to avoid above weaknesses. No functional changes introduced. Signed-off-by: Gavin Shan --- arch/powerpc/kernel/eeh_pe.c | 28 1 file changed, 12 insertions(+), 16