Re: [PATCH 2/2] powerpc/msi: Use WARN_ON() in msi bitmap selftests

2014-10-10 Thread Laurentiu Tudor
Hi Michael, Comment inline. On 10/10/2014 11:04 AM, Michael Ellerman wrote: > As demonstrated in the previous commit, the failure message from the msi > bitmap selftests is a bit subtle, it's easy to miss a failure in a busy > boot log. > > So drop our check() macro and use WARN_ON() instead. Th

[PATCH 2/2] powerpc/msi: Use WARN_ON() in msi bitmap selftests

2014-10-10 Thread Michael Ellerman
As demonstrated in the previous commit, the failure message from the msi bitmap selftests is a bit subtle, it's easy to miss a failure in a busy boot log. So drop our check() macro and use WARN_ON() instead. This necessitates inverting all the conditions as well. Signed-off-by: Michael Ellerman