Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-09 Thread Michael Ellerman
On Fri, 2016-05-06 at 13:00 +1000, Suraj Jitindar Singh wrote: > On 05/05/16 16:50, Michael Ellerman wrote: > > On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: > > > On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: > > > > diff --git a/arch/powerpc/platforms/pseries/mobility.c > > > >

Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-05 Thread Suraj Jitindar Singh
On 05/05/16 16:50, Michael Ellerman wrote: > On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: >> On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: >>> diff --git a/arch/powerpc/platforms/pseries/mobility.c >>> b/arch/powerpc/platforms/pseries/mobility.c >>> index ceb18d3..a560a98 10064

Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-05 Thread Suraj Jitindar Singh
On 05/05/16 16:50, Michael Ellerman wrote: > On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: >> On 04/27/2016 > 10:34 PM, Suraj Jitindar Singh wrote: >>> diff --git > a/arch/powerpc/platforms/pseries/mobility.c > b/arch/powerpc/platforms/pseries/mobility.c >>> index ceb18d3..a560a98 1

Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-04 Thread Michael Ellerman
On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: > On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: > > diff --git a/arch/powerpc/platforms/pseries/mobility.c > > b/arch/powerpc/platforms/pseries/mobility.c > > index ceb18d3..a560a98 100644 > > --- a/arch/powerpc/platforms/pseries/mobil

Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-05-03 Thread Tyrel Datwyler
On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: > After obtaining a property from of_find_property() and before calling > of_remove_property() most code checks to ensure that the property > returned from of_find_property() is not null. The previous patch > moved this check to the start of the f

[PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking

2016-04-27 Thread Suraj Jitindar Singh
After obtaining a property from of_find_property() and before calling of_remove_property() most code checks to ensure that the property returned from of_find_property() is not null. The previous patch moved this check to the start of the function of_remove_property() in order to avoid the case wher