Re: [PATCH 2/2] powerpc: create mpc85xx pci err platform device for EDAC

2008-02-13 Thread Dave Jiang
Kumar Gala wrote: > On Feb 11, 2008, at 2:34 PM, Dave Jiang wrote: > >> Creating a platform device for the PCI error registers in order for >> the >> mpc85xx EDAC driver to pick up proper resources. This is to prevent >> the >> EDAC driver from monopolizing the of_device and thus preventing

Re: [PATCH 2/2] powerpc: create mpc85xx pci err platform device for EDAC

2008-02-11 Thread Stephen Rothwell
Hi Dave, On Mon, 11 Feb 2008 13:34:45 -0700 Dave Jiang <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/sysdev/fsl_pci.c > +static int __init mpc85xx_pcierr_setup(void) > +{ > + struct device_node *np = NULL; You don't need to initialiase this as it is first used in for_each_compatible_node(

Re: [PATCH 2/2] powerpc: create mpc85xx pci err platform device for EDAC

2008-02-11 Thread Kumar Gala
On Feb 11, 2008, at 2:34 PM, Dave Jiang wrote: > Creating a platform device for the PCI error registers in order for > the > mpc85xx EDAC driver to pick up proper resources. This is to prevent > the > EDAC driver from monopolizing the of_device and thus preventing > future PCI > code from u

[PATCH 2/2] powerpc: create mpc85xx pci err platform device for EDAC

2008-02-11 Thread Dave Jiang
Creating a platform device for the PCI error registers in order for the mpc85xx EDAC driver to pick up proper resources. This is to prevent the EDAC driver from monopolizing the of_device and thus preventing future PCI code from using the PCI of_device(s). Signed-off-by: Dave Jiang <[EMAIL PROTECT