Re: [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset.

2010-06-09 Thread Mark Brown
On Tue, Jun 08, 2010 at 12:46:02PM -0400, Eric Millbrandt wrote: > + switch (psc_dma->id) { > + case 0: > + gpio_mux = MPC52xx_GPIO_PSC1_MASK; break; > + case 1: > + gpio_mux = MPC52xx_GPIO_PSC2_MASK; break; Please don't place the break on the same li

[PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset.

2010-06-08 Thread Eric Millbrandt
The implementation of the ac97 "cold" reset is flawed. If the sync and output lines are high when reset is asserted the attached ac97 device may go into test mode. Avoid this by reconfiguring the psc to gpio mode and generating the reset manually. Signed-off-by: Eric Millbrandt --- arch/powerp