Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-10 Thread Stefan Roese
On Wednesday 10 October 2007, Josh Boyer wrote: > > > Do you really need config options for 405EP/EX? I don't seem them used > > > anywhere else in the code (and it's also contradictory to the whole new > > > multiplatform way of looking at stuff :). > > > > > > I know the 405/440 is still somewhat

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-10 Thread Josh Boyer
On Mon, 2007-10-08 at 11:08 +0200, Stefan Roese wrote: > This patch adds basic support for the new 405EX and the AMCC eval board > Kilauea to arch/powerpc. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/40x/Kconfig | 17 +++-- > arch/powerpc/platforms/4

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-10 Thread Josh Boyer
On Tue, 2007-10-09 at 13:34 +0200, Stefan Roese wrote: > Hi Olof, > > On Monday 08 October 2007, Olof Johansson wrote: > > > +config KILAUEA > > > + bool "Kilauea" > > > + depends on 40x > > > + default y > > > + select 405EX > > > + help > > > + This option enables support for the AMCC PPC405EX

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-09 Thread Stefan Roese
Hi Olof, On Monday 08 October 2007, Olof Johansson wrote: > > +config KILAUEA > > + bool "Kilauea" > > + depends on 40x > > + default y > > + select 405EX > > + help > > + This option enables support for the AMCC PPC405EX evaluation board. > > + > > #config REDWOOD_5 > > # bool "R

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-08 Thread Olof Johansson
Hi, On Mon, Oct 08, 2007 at 11:08:51AM +0200, Stefan Roese wrote: > This patch adds basic support for the new 405EX and the AMCC eval board > Kilauea to arch/powerpc. [...] > +config KILAUEA > + bool "Kilauea" > + depends on 40x > + default y > + select 405EX > + help > +

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-08 Thread Stefan Roese
On Monday 08 October 2007, Stephen Rothwell wrote: > > +#include > > Here I go again :-) > > linux/of_platform.h please Right. I was watching all your reviews lately and wanted not to make this error. Didn't work out as it seems. :-) I'll wait a while for further comments and send a fixed versi

Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-08 Thread Stephen Rothwell
On Mon, 8 Oct 2007 11:08:51 +0200 Stefan Roese <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/40x/kilauea.c > > +#include Here I go again :-) linux/of_platform.h please -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpBkEhy7sc

[PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

2007-10-08 Thread Stefan Roese
This patch adds basic support for the new 405EX and the AMCC eval board Kilauea to arch/powerpc. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- arch/powerpc/platforms/40x/Kconfig | 17 +++-- arch/powerpc/platforms/40x/Makefile |5 ++- arch/powerpc/platforms/40x/kilauea.c | 63