Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-09 Thread David Gibson
On Sun, Jan 06, 2008 at 04:46:24PM -0600, Scott Wood wrote: On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote: out: + free((void *)file-dir); That cast shouldn't be there. It generates a constness warning otherwise. I was on the fence over whether to just remove the

Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-07 Thread Jon Loeliger
So, like, the other day Scott Wood mumbled: Also, free file-dir when freeing file. Signed-off-by: Scott Wood [EMAIL PROTECTED] Applied. Thanks. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-07 Thread Jon Loeliger
So, like, the other day Scott Wood mumbled: On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote: out: + free((void *)file-dir); That cast shouldn't be there. It generates a constness warning otherwise. I was on the fence over whether to just remove the constness (even

Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-06 Thread Scott Wood
On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote: out: + free((void *)file-dir); That cast shouldn't be there. It generates a constness warning otherwise. I was on the fence over whether to just remove the constness (even though the data is never modified during its

Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-05 Thread David Gibson
On Fri, Jan 04, 2008 at 03:10:45PM -0600, Scott Wood wrote: Also, free file-dir when freeing file. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- srcpos.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/srcpos.c b/srcpos.c index 7340c33..7a0c47e

[PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-04 Thread Scott Wood
Also, free file-dir when freeing file. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- srcpos.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/srcpos.c b/srcpos.c index 7340c33..7a0c47e 100644 --- a/srcpos.c +++ b/srcpos.c @@ -86,6 +86,16 @@ struct dtc_file