Re: [PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-04-27 Thread Jean Delvare
On Sun, 27 Jan 2008 10:40:19 -0800, David Brownell wrote: > General comment: if you're going to index arrays by enum > values, it's best to initialize them that way too. Else > you're expecting a particular optional policy for how the > enums get grown... > > - Dave > > > On Monday 21 January

Re: [PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-01-27 Thread Jon Smirl
On 1/27/08, David Brownell <[EMAIL PROTECTED]> wrote: > General comment: if you're going to index arrays by enum > values, it's best to initialize them that way too. Else > you're expecting a particular optional policy for how the > enums get grown... Even better is the way the m41t80 driver doe

Re: [PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-01-27 Thread David Brownell
General comment: if you're going to index arrays by enum values, it's best to initialize them that way too. Else you're expecting a particular optional policy for how the enums get grown... - Dave On Monday 21 January 2008, Jean Delvare wrote: > --- linux-2.6.24-rc8.orig/drivers/rtc/rtc-ds1307

Re: [PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-01-22 Thread Jean Delvare
Hi Jon, On Mon, 21 Jan 2008 11:50:13 -0500, Jon Smirl wrote: > In my version of these patches new style drivers could be loaded with > both the driver_name/name scheme and the modalias. In these patches > new style drivers can only be loaded via modalias. Is that what you > intended? I'm all for m

Re: [PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-01-21 Thread Jon Smirl
In my version of these patches new style drivers could be loaded with both the driver_name/name scheme and the modalias. In these patches new style drivers can only be loaded via modalias. Is that what you intended? I'm all for making new style driver only use the modalias scheme. -- Jon Smirl [E

[PATCH 2/3] i2c: Convert all new-style drivers to use module aliasing

2008-01-21 Thread Jean Delvare
Based on earlier work by Jon Smirl. Update all the new-style i2c drivers to use standard module aliasing instead of the old driver_name/type driver matching scheme. Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> Cc: Jon Smirl <[EMAIL PROTECTED]> --- arch/arm/mach-at91/board-csb337.c |3 - a