> On Nov 28, 2023, at 9:21 AM, Nathan Lynch wrote:
>
> Nick Child writes:
>> Hi Nathan,
>> Patches 1 and 3 LGTM
>
> thanks.
>
>> Regarding this patch, dlpar_memory_remove_by_count() calls
>> dlpar_add_lmb() and does not free drc on add error.
>> dlpar_add_lmb() is called here in error
Nick Child writes:
> Hi Nathan,
> Patches 1 and 3 LGTM
thanks.
> Regarding this patch, dlpar_memory_remove_by_count() calls
> dlpar_add_lmb() and does not free drc on add error.
> dlpar_add_lmb() is called here in error recovery so probably
> not a big deal.
>
> This is all new code to me but
Hi Nathan,
Patches 1 and 3 LGTM
Regarding this patch, dlpar_memory_remove_by_count() calls
dlpar_add_lmb() and does not free drc on add error.
dlpar_add_lmb() is called here in error recovery so probably
not a big deal.
This is all new code to me but it looks like if the requested
number of
From: Nathan Lynch
Callers of dlpar_add_lmb() are responsible for first acquiring the DRC
and releasing it if dlpar_add_lmb() fails.
However, dlpar_add_lmb() performs a dlpar_release_drc() in one error
branch. There is no corresponding dlpar_acquire_drc() in the
function, nor is there any
