Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-26 Thread Gabriel Paubert
On Wed, Jun 25, 2008 at 11:17:45AM -0500, Scott Wood wrote: > Gabriel Paubert wrote: > >On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: > >>Kumar Gala wrote: > +/* Macros to workout the correct index for the FPR in the thread > struct */ > +#define FPRNUMBER(i) (((i) - PT_F

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > > On Jun 25, 2008, at 11:17 AM, Scott Wood wrote: > > > Gabriel Paubert wrote: > >> On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: > >>> Kumar Gala wrote: > > +/* Macros to workout the correct index for the FPR in the > > thread s

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Andreas Schwab
Gabriel Paubert <[EMAIL PROTECTED]> writes: > On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: >> Kumar Gala wrote: >> >>+/* Macros to workout the correct index for the FPR in the thread >> >>struct */ >> >>+#define FPRNUMBER(i) (((i) - PT_FPR0) >> 1) >> >>+#define FPRHALF(i) (((i) - P

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Kumar Gala
On Jun 25, 2008, at 11:17 AM, Scott Wood wrote: Gabriel Paubert wrote: On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: Kumar Gala wrote: +/* Macros to workout the correct index for the FPR in the thread struct */ +#define FPRNUMBER(i) (((i) - PT_FPR0) >> 1) +#define FPRHALF(i)

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Gabriel Paubert
On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: > Kumar Gala wrote: > >>+/* Macros to workout the correct index for the FPR in the thread > >>struct */ > >>+#define FPRNUMBER(i) (((i) - PT_FPR0) >> 1) > >>+#define FPRHALF(i) (((i) - PT_FPR0) % 2) > > > >Have you looked at what the comp

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Scott Wood
Gabriel Paubert wrote: On Wed, Jun 25, 2008 at 10:34:32AM -0500, Scott Wood wrote: Kumar Gala wrote: +/* Macros to workout the correct index for the FPR in the thread struct */ +#define FPRNUMBER(i) (((i) - PT_FPR0) >> 1) +#define FPRHALF(i) (((i) - PT_FPR0) % 2) Have you looked at what the co

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Scott Wood
Kumar Gala wrote: +/* Macros to workout the correct index for the FPR in the thread struct */ +#define FPRNUMBER(i) (((i) - PT_FPR0) >> 1) +#define FPRHALF(i) (((i) - PT_FPR0) % 2) Have you looked at what the compiler spits out here to make sure we aren't getting a divide? Seems like we coul

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-25 Thread Kumar Gala
Index: linux-2.6-ozlabs/arch/powerpc/kernel/ptrace32.c === --- linux-2.6-ozlabs.orig/arch/powerpc/kernel/ptrace32.c +++ linux-2.6-ozlabs/arch/powerpc/kernel/ptrace32.c @@ -64,6 +64,11 @@ static long compat_ptrace_old(struct tas

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-24 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c |

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-24 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote : > > On Jun 24, 2008, at 5:57 AM, Michael Neuling wrote: > > > We are going to change where the floating point registers are stored > > in the thread_struct, so in preparation add some macros to access the > > floating point registers. Update all code

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-24 Thread Segher Boessenkool
return user_regset_copyout(&pos, &count, &kbuf, &ubuf, - &target->thread.fpr, 0, -1); + target->thread.fpr, 0, -1); is there a reason we can drop the '&'? Yes, .fpr is an array. C is _such_ a fun language, heh. Segher

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-24 Thread Kumar Gala
On Jun 24, 2008, at 5:57 AM, Michael Neuling wrote: We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EM

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-24 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c |

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-23 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c |

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-22 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c |

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-22 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote : > > On Jun 19, 2008, at 11:13 PM, Michael Neuling wrote: > > > Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h > > === > > --- linux-2.6-ozlabs.orig/include/asm-powerpc/processor.h

Re: [PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-19 Thread Kumar Gala
On Jun 19, 2008, at 11:13 PM, Michael Neuling wrote: Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h === --- linux-2.6-ozlabs.orig/include/asm-powerpc/processor.h +++ linux-2.6-ozlabs/include/asm-powerpc/processor.h @@ -136

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-19 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c

[PATCH 2/9] powerpc: Add macros to access floating point registers in thread_struct.

2008-06-17 Thread Michael Neuling
We are going to change where the floating point registers are stored in the thread_struct, so in preparation add some macros to access the floating point registers. Update all code to use these new macros. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/align.c