Re: [PATCH 3/3] Return a non-zero exit code if an error occurs during dts parsing.

2008-01-10 Thread Scott Wood
David Gibson wrote: On Sun, Jan 06, 2008 at 04:55:09PM -0600, Scott Wood wrote: On Fri, Jan 04, 2008 at 03:30:33PM +1100, David Gibson wrote: This is unequivocally wrong. boot_info should have information about the contents of the blob, not state information like the error. This blob is

Re: [PATCH 3/3] Return a non-zero exit code if an error occurs during dts parsing.

2008-01-06 Thread Scott Wood
On Fri, Jan 04, 2008 at 03:30:33PM +1100, David Gibson wrote: This is unequivocally wrong. boot_info should have information about the contents of the blob, not state information like the error. This blob is invalid *is* information about the contents of the blob. If you're going to use an

Re: [PATCH 3/3] Return a non-zero exit code if an error occurs during dts parsing.

2008-01-05 Thread David Gibson
On Thu, Jan 03, 2008 at 05:43:33PM -0600, Scott Wood wrote: Previously, only failure to parse caused the reading of the tree to fail; semantic errors that called yyerror() but not YYERROR only emitted a message, without signalling make to stop the build. This one, however, I don't like.

[PATCH 3/3] Return a non-zero exit code if an error occurs during dts parsing.

2008-01-03 Thread Scott Wood
Previously, only failure to parse caused the reading of the tree to fail; semantic errors that called yyerror() but not YYERROR only emitted a message, without signalling make to stop the build. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- dtc-parser.y |2 ++ dtc.c|2 +- dtc.h