Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-18 Thread Christophe Leroy
Le 18/06/2020 à 02:58, Michael Ellerman a écrit : Peter Zijlstra writes: On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: Peter Zijlstra writes: On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: +#if defined(CONFIG_PPC_8xx) &&

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-18 Thread Christophe Leroy
Le 18/06/2020 à 03:00, Michael Ellerman a écrit : Christophe Leroy writes: Le 17/06/2020 à 16:38, Peter Zijlstra a écrit : On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: Peter Zijlstra writes: On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: +#if

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-17 Thread Michael Ellerman
Christophe Leroy writes: > Le 17/06/2020 à 16:38, Peter Zijlstra a écrit : >> On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: >>> Peter Zijlstra writes: On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: >> > +#if defined(CONFIG_PPC_8xx) &&

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-17 Thread Michael Ellerman
Peter Zijlstra writes: > On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: >> Peter Zijlstra writes: >> > On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: > >> >> +#if defined(CONFIG_PPC_8xx) && defined(CONFIG_PPC_16K_PAGES) >> >> +#define __HAVE_ARCH_PTEP_GET >>

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-17 Thread Christophe Leroy
Le 17/06/2020 à 16:38, Peter Zijlstra a écrit : On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: Peter Zijlstra writes: On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: +#if defined(CONFIG_PPC_8xx) && defined(CONFIG_PPC_16K_PAGES) +#define

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-17 Thread Peter Zijlstra
On Thu, Jun 18, 2020 at 12:21:22AM +1000, Michael Ellerman wrote: > Peter Zijlstra writes: > > On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: > >> +#if defined(CONFIG_PPC_8xx) && defined(CONFIG_PPC_16K_PAGES) > >> +#define __HAVE_ARCH_PTEP_GET > >> +static inline pte_t

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-17 Thread Michael Ellerman
Peter Zijlstra writes: > On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: >> READ_ONCE() now enforces atomic read, which leads to: > >> Fixes: 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() >> memory accesses") >> Cc: Will Deacon >> Signed-off-by:

Re: [PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 12:57:59PM +, Christophe Leroy wrote: > READ_ONCE() now enforces atomic read, which leads to: > Fixes: 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() > memory accesses") > Cc: Will Deacon > Signed-off-by: Christophe Leroy > --- >

[PATCH 3/3] powerpc/8xx: Provide ptep_get() with 16k pages

2020-06-15 Thread Christophe Leroy
READ_ONCE() now enforces atomic read, which leads to: CC mm/gup.o In file included from ./include/linux/kernel.h:11:0, from mm/gup.c:2: In function 'gup_hugepte.constprop', inlined from 'gup_huge_pd.isra.79' at mm/gup.c:2465:8: ./include/linux/compiler.h:392:38: error: