[PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
512x is very similar to 83xx and most of this is patterned after code from 83xx New platform: changed: arch/powerpc/Kconfig arch/powerpc/platforms/Kconfig arch/powerpc/platforms/Kconfig.cputype arch/powerpc/platforms/Makefile new:

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Grant Likely
Looks pretty good; major comment is that it should be multiplatform enabled. Cheers, g. On 1/8/08, John Rigby [EMAIL PROTECTED] wrote: 512x is very similar to 83xx and most of this is patterned after code from 83xx New platform: changed: arch/powerpc/Kconfig

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Jon Loeliger
So, like, the other day Olof Johansson mumbled: @@ -0,0 +1,90 @@ +#include asm/system.h +#include asm/atomic.h +#include asm/machdep.h +#include asm/ipic.h +#include asm/prom.h +#include asm/time.h +#include asm/of_platform.h Stephen will tell you to include

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Scott Wood
On Tue, Jan 08, 2008 at 10:19:20AM -0700, Grant Likely wrote: +config MPC5121_ADS + bool Freescale MPC5121E ADS + select DEFAULT_UIMAGE + help + This option enables support for the MPC5121E ADS board. Make this depend on PPC_MULTIPLATFORM and PPC32 I don't

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Olof Johansson
Hi, diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 66a3d8c..81c3f05 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -470,7 +470,7 @@ config PCI bool PCI support if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \ || PPC_MPC52xx ||

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Grant Likely
On 1/8/08, Scott Wood [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 10:19:20AM -0700, Grant Likely wrote: +config MPC5121_ADS + bool Freescale MPC5121E ADS + select DEFAULT_UIMAGE + help + This option enables support for the MPC5121E ADS board. Make

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2008, John Rigby wrote:  obj-$(CONFIG_PPC_CHRP) += chrp/  obj-$(CONFIG_40x)  += 40x/  obj-$(CONFIG_44x)  += 44x/ +obj-$(CONFIG_PPC_512x) += 512x/  obj-$(CONFIG_PPC_MPC52xx)  += 52xx/  obj-$(CONFIG_PPC_8xx)  += 8xx/  

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
Olof Johansson wrote: Hi, diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 66a3d8c..81c3f05 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -470,7 +470,7 @@ config PCI bool PCI support if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
@@ -229,7 +229,7 @@ config NR_CPUS config NOT_COHERENT_CACHE bool -depends on 4xx || 8xx || E200 +depends on 4xx || 8xx || E200 || PPC_512x default y Why do you need this, when 5200 doesn't? Because the 5121 cache is not coherent. The 5121 is not

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread John Rigby
Arnd Bergmann wrote: On Tuesday 08 January 2008, John Rigby wrote: obj-$(CONFIG_PPC_CHRP) += chrp/ obj-$(CONFIG_40x) += 40x/ obj-$(CONFIG_44x) += 44x/ +obj-$(CONFIG_PPC_512x) += 512x/ obj-$(CONFIG_PPC_MPC52xx) += 52xx/

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2008, Olof Johansson wrote: diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 66a3d8c..81c3f05 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -470,7 +470,7 @@ config PCI   bool PCI support if 40x || CPM2 || PPC_83xx || PPC_85xx ||

Re: [PATCH 3/7] Basic Freescale MPC512x support

2008-01-08 Thread Scott Wood
On Tue, Jan 08, 2008 at 10:56:41AM -0700, Grant Likely wrote: On 1/8/08, Scott Wood [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 10:19:20AM -0700, Grant Likely wrote: +config MPC5121_ADS + bool Freescale MPC5121E ADS + select DEFAULT_UIMAGE + help +

Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support]

2008-01-08 Thread John Rigby
It may work, but it pulls in code like prom_init.c that is not needed on non-OF boards. It's also quite confusing to have an embedded board's checkbox only show up when you say yes to Generic desktop/server/laptop. I have to agree with this, I have been confused by this myself. Perhaps

Re: Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support]

2008-01-08 Thread Grant Likely
On 1/8/08, John Rigby [EMAIL PROTECTED] wrote: It may work, but it pulls in code like prom_init.c that is not needed on non-OF boards. It's also quite confusing to have an embedded board's checkbox only show up when you say yes to Generic desktop/server/laptop. I have to agree with

Re: Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support]

2008-01-08 Thread Scott Wood
Grant Likely wrote: On 1/8/08, John Rigby [EMAIL PROTECTED] wrote: It may work, but it pulls in code like prom_init.c that is not needed on non-OF boards. It's also quite confusing to have an embedded board's checkbox only show up when you say yes to Generic desktop/server/laptop. I have to