Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-02 Thread Michael Ellerman
On Thu, 2016-06-02 at 17:13 +0530, Viresh Kumar wrote: > On 02-06-16, 21:37, Michael Ellerman wrote: > > On Thu, 2016-06-02 at 16:52 +0530, Viresh Kumar wrote: > > > On 02-06-16, 21:08, Michael Ellerman wrote: > > > > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > > > > > > > > > The

Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-02 Thread Viresh Kumar
On 02-06-16, 21:37, Michael Ellerman wrote: > On Thu, 2016-06-02 at 16:52 +0530, Viresh Kumar wrote: > > On 02-06-16, 21:08, Michael Ellerman wrote: > > > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > > > > > > > The policy is copied (unnecessarily) and is never freed. Fix it by just >

Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-02 Thread Michael Ellerman
On Thu, 2016-06-02 at 16:52 +0530, Viresh Kumar wrote: > On 02-06-16, 21:08, Michael Ellerman wrote: > > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > > > > > The policy is copied (unnecessarily) and is never freed. Fix it by just > > > getting a reference to the existing policy

Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-02 Thread Viresh Kumar
On 02-06-16, 21:08, Michael Ellerman wrote: > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > > > The policy is copied (unnecessarily) and is never freed. Fix it by just > > getting a reference to the existing policy structure and putting it > > back. > > > > Signed-off-by: Viresh Kumar

Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-02 Thread Michael Ellerman
On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > The policy is copied (unnecessarily) and is never freed. Fix it by just > getting a reference to the existing policy structure and putting it > back. > > Signed-off-by: Viresh Kumar When was it broken, always?

[PATCH 3/8] cpufreq: powerenv: Fix memory leak

2016-06-01 Thread Viresh Kumar
The policy is copied (unnecessarily) and is never freed. Fix it by just getting a reference to the existing policy structure and putting it back. Signed-off-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 15 +-- 1 file changed, 9 insertions(+), 6