Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2019 at 04:55:05PM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:18, Andy Shevchenko wrote: > > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> - int ret = 0; > > > > This and Co is a separate change that can be done

Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 28.04.19 17:18, Andy Shevchenko wrote: > On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult > wrote: >> The io resource size is currently recomputed when it's needed but this >> actually needs to be done once (or drivers could specify fixed values) > > io -> IO fixed.

Re: [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-28 Thread Andy Shevchenko
On Sat, Apr 27, 2019 at 02:52:17PM +0200, Enrico Weigelt, metux IT consult wrote: > The io resource size is currently recomputed when it's needed but this > actually needs to be done once (or drivers could specify fixed values) io -> IO > > Simplify that by doing this computation only once and

[PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct

2019-04-27 Thread Enrico Weigelt, metux IT consult
The io resource size is currently recomputed when it's needed but this actually needs to be done once (or drivers could specify fixed values) Simplify that by doing this computation only once and storing the result into the mapsize field. serial8250_register_8250_port() is now called only once on