Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-18 Thread Nicholas Piggin
Christophe Leroy's on June 11, 2019 3:39 pm: > > > Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : >> For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to >> allocate huge pages and map them > > Will this be compatible with Russell's series >

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-18 Thread Nicholas Piggin
Anshuman Khandual's on June 11, 2019 4:17 pm: > > > On 06/10/2019 08:14 PM, Nicholas Piggin wrote: >> Mark Rutland's on June 11, 2019 12:10 am: >>> Hi, >>> >>> On Mon, Jun 10, 2019 at 02:38:38PM +1000, Nicholas Piggin wrote: For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-18 Thread Nicholas Piggin
Anshuman Khandual's on June 11, 2019 4:59 pm: > On 06/11/2019 05:46 AM, Nicholas Piggin wrote: >> Anshuman Khandual's on June 10, 2019 6:53 pm: >>> On 06/10/2019 10:08 AM, Nicholas Piggin wrote: For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to allocate huge pages

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-11 Thread Anshuman Khandual
On 06/11/2019 05:46 AM, Nicholas Piggin wrote: > Anshuman Khandual's on June 10, 2019 6:53 pm: >> On 06/10/2019 10:08 AM, Nicholas Piggin wrote: >>> For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to >>> allocate huge pages and map them. >> >> IIUC that extends

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-11 Thread Anshuman Khandual
On 06/10/2019 08:14 PM, Nicholas Piggin wrote: > Mark Rutland's on June 11, 2019 12:10 am: >> Hi, >> >> On Mon, Jun 10, 2019 at 02:38:38PM +1000, Nicholas Piggin wrote: >>> For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to >>> allocate huge pages and map them >>> >>>

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Christophe Leroy
Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to allocate huge pages and map them Will this be compatible with Russell's series https://patchwork.ozlabs.org/patch/1099857/ for the implementation of STRICT_MODULE_RWX

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Nicholas Piggin
Anshuman Khandual's on June 10, 2019 6:53 pm: > On 06/10/2019 10:08 AM, Nicholas Piggin wrote: >> For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to >> allocate huge pages and map them. > > IIUC that extends HAVE_ARCH_HUGE_VMAP from iormap to vmalloc. > >> >> This brings

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Nicholas Piggin
Mark Rutland's on June 11, 2019 12:10 am: > Hi, > > On Mon, Jun 10, 2019 at 02:38:38PM +1000, Nicholas Piggin wrote: >> For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to >> allocate huge pages and map them >> >> This brings dTLB misses for linux kernel tree `git diff`

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Mark Rutland
Hi, On Mon, Jun 10, 2019 at 02:38:38PM +1000, Nicholas Piggin wrote: > For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to > allocate huge pages and map them > > This brings dTLB misses for linux kernel tree `git diff` from 45,000 to > 8,000 on a Kaby Lake KVM guest with

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Anshuman Khandual
On 06/10/2019 10:08 AM, Nicholas Piggin wrote: > For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to > allocate huge pages and map them. IIUC that extends HAVE_ARCH_HUGE_VMAP from iormap to vmalloc. > > This brings dTLB misses for linux kernel tree `git diff` from 45,000

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-10 Thread Satheesh Rajendran
On Mon, Jun 10, 2019 at 03:49:48PM +1000, Nicholas Piggin wrote: > Nicholas Piggin's on June 10, 2019 2:38 pm: > > +static int vmap_hpages_range(unsigned long start, unsigned long end, > > + pgprot_t prot, struct page **pages, > > + unsigned int

Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-09 Thread Nicholas Piggin
Nicholas Piggin's on June 10, 2019 2:38 pm: > +static int vmap_hpages_range(unsigned long start, unsigned long end, > +pgprot_t prot, struct page **pages, > +unsigned int page_shift) > +{ > + BUG_ON(page_shift != PAGE_SIZE); > + return

[PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings

2019-06-09 Thread Nicholas Piggin
For platforms that define HAVE_ARCH_HUGE_VMAP, have vmap allow vmalloc to allocate huge pages and map them This brings dTLB misses for linux kernel tree `git diff` from 45,000 to 8,000 on a Kaby Lake KVM guest with 8MB dentry hash and mitigations=off (performance is in the noise, under 1%