Re: [PATCH 4/4] powerpc/kprobes: refactor kprobe_lookup_name for safer string operations

2017-10-27 Thread Naveen N. Rao
On 2017/10/25 04:35PM, Masami Hiramatsu wrote: > On Mon, 23 Oct 2017 22:07:41 +0530 > "Naveen N. Rao" wrote: > > > Use safer string manipulation functions when dealing with a > > user-provided string in kprobe_lookup_name(). > > > > What would you mean "safer"

Re: [PATCH 4/4] powerpc/kprobes: refactor kprobe_lookup_name for safer string operations

2017-10-25 Thread Masami Hiramatsu
On Mon, 23 Oct 2017 22:07:41 +0530 "Naveen N. Rao" wrote: > Use safer string manipulation functions when dealing with a > user-provided string in kprobe_lookup_name(). > What would you mean "safer" here? using strnchr()? Could you please show at least an

[PATCH 4/4] powerpc/kprobes: refactor kprobe_lookup_name for safer string operations

2017-10-23 Thread Naveen N. Rao
Use safer string manipulation functions when dealing with a user-provided string in kprobe_lookup_name(). Reported-by: David Laight Signed-off-by: Naveen N. Rao --- arch/powerpc/kernel/kprobes.c | 47