Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-17 Thread Kim Phillips
On Thu, 17 Jul 2008 10:51:43 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Jul 17, 2008, at 10:27 AM, Kim Phillips wrote: > > > On Thu, 17 Jul 2008 07:26:14 -0500 > > Kumar Gala <[EMAIL PROTECTED]> wrote: > > > >> > >> On Jul 17, 2008, at 7:17 AM, Herbert Xu wrote: > >> > >>> On Wed, Jul 16

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-17 Thread Kumar Gala
On Jul 17, 2008, at 10:27 AM, Kim Phillips wrote: On Thu, 17 Jul 2008 07:26:14 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: On Jul 17, 2008, at 7:17 AM, Herbert Xu wrote: On Wed, Jul 16, 2008 at 06:33:45PM -0500, Kumar Gala wrote: On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: use GFP

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-17 Thread Kim Phillips
On Thu, 17 Jul 2008 07:26:14 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Jul 17, 2008, at 7:17 AM, Herbert Xu wrote: > > > On Wed, Jul 16, 2008 at 06:33:45PM -0500, Kumar Gala wrote: > >> > >> On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: > >> > >>> use GFP_ATOMIC when necessary; use a

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-17 Thread Kumar Gala
On Jul 17, 2008, at 7:17 AM, Herbert Xu wrote: On Wed, Jul 16, 2008 at 06:33:45PM -0500, Kumar Gala wrote: On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: use GFP_ATOMIC when necessary; use atomic_t when allocating submit_count. why? You mean why are atomics required? Yes that is a goo

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-17 Thread Herbert Xu
On Wed, Jul 16, 2008 at 06:33:45PM -0500, Kumar Gala wrote: > > On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: > > >use GFP_ATOMIC when necessary; use atomic_t when allocating > >submit_count. > > why? You mean why are atomics required? Yes that is a good question. Kim? Cheers, -- Visit

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-16 Thread Kumar Gala
On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: use GFP_ATOMIC when necessary; use atomic_t when allocating submit_count. why? - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-16 Thread Kim Phillips
use GFP_ATOMIC when necessary; use atomic_t when allocating submit_count. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Acked-by: Lee Nipper <[EMAIL PROTECTED]> --- drivers/crypto/talitos.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/talitos.c b/