Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-19 Thread Mahesh Jagannath Salgaonkar
On 03/16/2017 06:49 PM, Gautham R Shenoy wrote: > Hi, > > On Thu, Mar 16, 2017 at 11:05:20PM +1000, Nicholas Piggin wrote: >> On Thu, 16 Mar 2017 18:10:48 +0530 >> Mahesh Jagannath Salgaonkar wrote: >> >>> On 03/14/2017 02:53 PM, Nicholas Piggin wrote: The ISA specifies power save wakeup can

Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-16 Thread Nicholas Piggin
On Fri, 17 Mar 2017 12:49:27 +1000 Nicholas Piggin wrote: > On Thu, 16 Mar 2017 18:10:48 +0530 > Mahesh Jagannath Salgaonkar wrote: > > > On 03/14/2017 02:53 PM, Nicholas Piggin wrote: > > Looks like we are not winding up.. Shouldn't we ? What if we may end up > > in pnv_wakeup_noloss() whic

Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-16 Thread Nicholas Piggin
On Thu, 16 Mar 2017 18:10:48 +0530 Mahesh Jagannath Salgaonkar wrote: > On 03/14/2017 02:53 PM, Nicholas Piggin wrote: > > The ISA specifies power save wakeup can cause a machine check interrupt. > > The machine check handler currently has code to handle that for POWER8, > > but POWER9 crashes wh

Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-16 Thread Gautham R Shenoy
Hi, On Thu, Mar 16, 2017 at 11:05:20PM +1000, Nicholas Piggin wrote: > On Thu, 16 Mar 2017 18:10:48 +0530 > Mahesh Jagannath Salgaonkar wrote: > > > On 03/14/2017 02:53 PM, Nicholas Piggin wrote: > > > The ISA specifies power save wakeup can cause a machine check interrupt. > > > The machine che

Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-16 Thread Nicholas Piggin
On Thu, 16 Mar 2017 18:10:48 +0530 Mahesh Jagannath Salgaonkar wrote: > On 03/14/2017 02:53 PM, Nicholas Piggin wrote: > > The ISA specifies power save wakeup can cause a machine check interrupt. > > The machine check handler currently has code to handle that for POWER8, > > but POWER9 crashes wh

Re: [PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-16 Thread Mahesh Jagannath Salgaonkar
On 03/14/2017 02:53 PM, Nicholas Piggin wrote: > The ISA specifies power save wakeup can cause a machine check interrupt. > The machine check handler currently has code to handle that for POWER8, > but POWER9 crashes when trying to execute the P8 style sleep > instructions. > > So queue up the mac

[PATCH 4/8] powerpc/64s: fix POWER9 machine check handler from stop state

2017-03-14 Thread Nicholas Piggin
The ISA specifies power save wakeup can cause a machine check interrupt. The machine check handler currently has code to handle that for POWER8, but POWER9 crashes when trying to execute the P8 style sleep instructions. So queue up the machine check, then call into the idle code to wake up as the