Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-08 Thread Vitaly Bordug
Hello Kumar, On Fri, 5 Oct 2007 15:58:00 -0500 Kumar Gala wrote: On Oct 5, 2007, at 1:05 PM, Anton Vorontsov wrote: On Fri, Oct 05, 2007 at 09:56:46PM +0400, Sergei Shtylyov wrote: Hello. Anton Vorontsov wrote: Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix

Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-08 Thread Anton Vorontsov
On Fri, Oct 05, 2007 at 03:58:00PM -0500, Kumar Gala wrote: On Oct 5, 2007, at 1:05 PM, Anton Vorontsov wrote: On Fri, Oct 05, 2007 at 09:56:46PM +0400, Sergei Shtylyov wrote: Hello. Anton Vorontsov wrote: Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix PCI/PCIe nodes, but

Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-08 Thread Kumar Gala
Which patch? Valentine's or mine under the subject? Don't know about the former, but mine patch is pretty obvious: your commit 5bece127f0666996ca90772229e00332a34e516c moved PCI nodes out of soc node, but you forgot to change regs = , thus instead of e000a000/ e0008000, kernel used

[PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-05 Thread Anton Vorontsov
Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix PCI/PCIe nodes, but actually it broke them even harder. ;-) Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8568mds.dts |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-05 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix PCI/PCIe nodes, but actually it broke them even harder. ;-) Of course. But shouldn't those be the subnoses of the soc type node? I don't suppose the PCI controllers could hang off the root node...

Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-05 Thread Anton Vorontsov
On Fri, Oct 05, 2007 at 09:56:46PM +0400, Sergei Shtylyov wrote: Hello. Anton Vorontsov wrote: Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix PCI/PCIe nodes, but actually it broke them even harder. ;-) Of course. But shouldn't those be the subnoses of the soc type node?

Re: [PATCH 6/7] [POWERPC] mpc8568mds.dts: fix PCI/PCIe nodes

2007-10-05 Thread Kumar Gala
On Oct 5, 2007, at 1:05 PM, Anton Vorontsov wrote: On Fri, Oct 05, 2007 at 09:56:46PM +0400, Sergei Shtylyov wrote: Hello. Anton Vorontsov wrote: Commit 5bece127f0666996ca90772229e00332a34e516c tried to fix PCI/PCIe nodes, but actually it broke them even harder. ;-) Of course. But