[PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Geert Uytterhoeven
Create a real RTC driver for PS3, and unhook the deprecated ppc_md.[gs]et_rtc_time. Signed-off-by: Geert Uytterhoeven Cc: Geoff Levand --- arch/powerpc/include/asm/ps3.h|3 + arch/powerpc/platforms/ps3/os-area.c |2 + arch/powerpc/platforms/ps3/platform.h |2 - arch/powerpc

Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Geoff Levand
On 03/09/2009 06:26 AM, Geert Uytterhoeven wrote: > Create a real RTC driver for PS3, and unhook the deprecated > ppc_md.[gs]et_rtc_time. > 8 files changed, 132 insertions(+), 18 deletions(-) Sorry, I hadn't been following the discussion closely, but could you explain why we are going from a gen

Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-10 Thread Geert Uytterhoeven
On Mon, 9 Mar 2009, Geoff Levand wrote: > On 03/09/2009 06:26 AM, Geert Uytterhoeven wrote: > > Create a real RTC driver for PS3, and unhook the deprecated > > ppc_md.[gs]et_rtc_time. > > > 8 files changed, 132 insertions(+), 18 deletions(-) > > Sorry, I hadn't been following the discussion clos

Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-10 Thread Geoff Levand
On 03/09/2009 06:26 AM, Geert Uytterhoeven wrote: > Create a real RTC driver for PS3, and unhook the deprecated > ppc_md.[gs]et_rtc_time. > > Signed-off-by: Geert Uytterhoeven > Cc: Geoff Levand > --- > arch/powerpc/include/asm/ps3.h|3 + > arch/powerpc/platforms/ps3/os-area.c |

Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Alessandro Zummo
On Mon, 9 Mar 2009 14:26:23 +0100 Geert Uytterhoeven wrote: Hi, just a few notes: > + > +static int ps3_get_time(struct device *dev, struct rtc_time *tm) > +{ > + to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm); > + tm->tm_year -= 1900; > + tm->tm_mon -= 1; > + return 0;

Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Geert Uytterhoeven
On Mon, 9 Mar 2009, Alessandro Zummo wrote: > On Mon, 9 Mar 2009 14:26:23 +0100 > Geert Uytterhoeven wrote: > > + > > +static int ps3_get_time(struct device *dev, struct rtc_time *tm) > > +{ > > + to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm); > > + tm->tm_year -= 1900; > > + tm->tm_mo

Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Geoff Levand
Hi, On 03/09/2009 07:12 AM, Alessandro Zummo wrote: > On Mon, 9 Mar 2009 14:26:23 +0100 > Geert Uytterhoeven wrote: >> + >> +MODULE_AUTHOR("Sony Corporation"); > > real name, if possible and a contact address > here . Just in case I need someone to bother :) Please look at the MAINTAINERS fi

Re: [rtc-linux] Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Alessandro Zummo
On Mon, 9 Mar 2009 11:04:17 -0700 Geoff Levand wrote: > > Hi, > > On 03/09/2009 07:12 AM, Alessandro Zummo wrote: > > On Mon, 9 Mar 2009 14:26:23 +0100 > > Geert Uytterhoeven wrote: > >> + > >> +MODULE_AUTHOR("Sony Corporation"); > > > > real name, if possible and a contact address > > her

Re: [rtc-linux] Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Geoff Levand
Hi, On 03/09/2009 11:43 AM, Alessandro Zummo wrote: > Geoff Levand wrote: >> On 03/09/2009 07:12 AM, Alessandro Zummo wrote: >> > On Mon, 9 Mar 2009 14:26:23 +0100 >> > Geert Uytterhoeven wrote: >> >> + >> >> +MODULE_AUTHOR("Sony Corporation"); >> > >> > real name, if possible and a contact a

Re: [rtc-linux] Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-09 Thread Joe Perches
On Mon, 2009-03-09 at 12:06 -0700, Geoff Levand wrote: > There was some work by Joe Perches to list the files a maintainer is > responsible for into the MAINTAINERS file. I think that would give > you what you want, a way to automatically get the maintainer of a > file. > > Joe, could you let us

Re: [rtc-linux] Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3

2009-03-10 Thread Alessandro Zummo
On Tue, 10 Mar 2009 10:21:14 +0100 (CET) Geert Uytterhoeven wrote: > Alessandro prefers not to have generic RTC drivers on top of some other > abstraction, but wants platform/chip-specific drivers under drivers/rtc/ > instead. The goal is to convert all RTC drivers buried in platform code > to se