Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-10-02 Thread David Gibson
On Fri, Sep 28, 2007 at 10:16:51AM -0500, Milton Miller wrote: [snip] Actually, there is another approach: put this converter in kexec's purgatory or even the kexec program. It can then run conditionally under command line flags to keep compatibility with the old kernels. If and when

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-28 Thread Milton Miller
On Sep 27, 2007, at 9:40 PM, David Gibson wrote: On Thu, Sep 27, 2007 at 10:44:27AM -0500, Milton Miller wrote: On Sep 26, 2007, at 9:45 PM, David Gibson wrote: The actual binary structure is compatable, just not the contents of the properties nor how any slave cpus wait (for some trees it

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-27 Thread Milton Miller
On Sep 26, 2007, at 9:45 PM, David Gibson wrote: On Wed, Sep 26, 2007 at 11:19:47AM -0500, Milton Miller wrote: On Sep 24, 2007, at 10:46 PM, David Gibson wrote: On Mon, Sep 24, 2007 at 01:54:32AM -0500, Milton Miller wrote: On Sep 23, 2007, at 10:36 PM, David Gibson wrote: On Fri, Sep 21,

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-27 Thread David Gibson
On Thu, Sep 27, 2007 at 10:44:27AM -0500, Milton Miller wrote: On Sep 26, 2007, at 9:45 PM, David Gibson wrote: [snip] What's your souce for saying the were supposed to be backwards compatable? That dtc fills out the struct header so? Sitting next to BenH and knowing he always intended

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-26 Thread David Gibson
On Wed, Sep 26, 2007 at 11:19:47AM -0500, Milton Miller wrote: On Sep 24, 2007, at 10:46 PM, David Gibson wrote: On Mon, Sep 24, 2007 at 01:54:32AM -0500, Milton Miller wrote: On Sep 23, 2007, at 10:36 PM, David Gibson wrote: On Fri, Sep 21, 2007 at 06:05:06PM -0500, Milton Miller wrote:

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-24 Thread Milton Miller
On Sep 23, 2007, at 10:36 PM, David Gibson wrote: On Fri, Sep 21, 2007 at 06:05:06PM -0500, Milton Miller wrote: kexec-tools still produces a version 2 device tree, while the libraries in the wrapper only support version 16 and later. Add a routine to convert a v2 flat device tree to a v16

Re: [PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-24 Thread David Gibson
On Mon, Sep 24, 2007 at 01:54:32AM -0500, Milton Miller wrote: On Sep 23, 2007, at 10:36 PM, David Gibson wrote: On Fri, Sep 21, 2007 at 06:05:06PM -0500, Milton Miller wrote: [snip] +#define MIN_VERSION 2 +#define OUT_VERSION 16 Should output version 17. In any case, don't try to

[PATCH 8/15] bootwrapper: convert flatdevtree to version 16

2007-09-21 Thread Milton Miller
kexec-tools still produces a version 2 device tree, while the libraries in the wrapper only support version 16 and later. Add a routine to convert a v2 flat device tree to a v16 one inplace by inserting OF_DT_NOP and chomping full path. Make space for new headers by moving and then chomping the