Re: [PATCH V2] cxl: Fix memory page not handled

2017-09-26 Thread christophe lombard
Le 26/09/2017 à 03:44, Vaibhav Jain a écrit : Hi Christophe, A minor nitpick Christophe Lombard writes: + for (dar = (addr & ~(page_size - 1)); dar < (addr + size); dar += page_size) { + if (dar < vma->vm_start || dar > vma->vm_end) { Code

Re: [PATCH V2] cxl: Fix memory page not handled

2017-09-25 Thread Andrew Donnellan
On 26/09/17 11:44, Vaibhav Jain wrote: Hi Christophe, A minor nitpick Christophe Lombard writes: + for (dar = (addr & ~(page_size - 1)); dar < (addr + size); dar += page_size) { + if (dar < vma->vm_start || dar > vma->vm_end) { Code comment

Re: [PATCH V2] cxl: Fix memory page not handled

2017-09-25 Thread Vaibhav Jain
Hi Christophe, A minor nitpick Christophe Lombard writes: > + for (dar = (addr & ~(page_size - 1)); dar < (addr + size); dar += > page_size) { > + if (dar < vma->vm_start || dar > vma->vm_end) { Code comment in mm_types.h for vm_end says it "The

Re: [PATCH V2] cxl: Fix memory page not handled

2017-09-25 Thread Andrew Donnellan
On 25/09/17 18:58, Christophe Lombard wrote: The in-kernel 'library' API can be called by drivers to help interaction with an IBM XSL on a POWER9 system. The cxllib_handle_fault() API is used to handle memory fault. All memory pages of the specified buffer have to be handled but under certain

Re: [PATCH V2] cxl: Fix memory page not handled

2017-09-25 Thread Frederic Barrat
Le 25/09/2017 à 10:58, Christophe Lombard a écrit : The in-kernel 'library' API can be called by drivers to help interaction with an IBM XSL on a POWER9 system. The cxllib_handle_fault() API is used to handle memory fault. All memory pages of the specified buffer have to be handled but under

[PATCH V2] cxl: Fix memory page not handled

2017-09-25 Thread Christophe Lombard
The in-kernel 'library' API can be called by drivers to help interaction with an IBM XSL on a POWER9 system. The cxllib_handle_fault() API is used to handle memory fault. All memory pages of the specified buffer have to be handled but under certain conditions,the last page may not be touched, and